Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: floating window tiling gaps #438

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

ryanabx
Copy link
Contributor

@ryanabx ryanabx commented Apr 20, 2024

Note: the images here are slightly old, the maximize state no longer has gaps, as @git-f0x pointed out that the maximized state in tiling mode doesn't have gaps

screenshot-2024-04-20-04-23-45

screenshot-2024-04-20-03-57-42

2024-04-19.23-21-18.mp4

Friendly reminder tiling gaps can be configured in cosmic settings > appearance !

@git-f0x
Copy link
Contributor

git-f0x commented Apr 20, 2024

While I'm not certain, I don't think maximize should have gaps, since it should probably match the behavior from clicking the maximize button (it doesn't have gaps when maximized in auto tiling).

@ryanabx
Copy link
Contributor Author

ryanabx commented Apr 20, 2024

While I'm not certain, I don't think maximize should have gaps, since it should probably match the behavior from clicking the maximize button (it doesn't have gaps when maximized in auto tiling).

Thanks for pointing that out to me! I never realized because I never maximize in tiling mode 😅

@wiiznokes
Copy link

wiiznokes commented Apr 20, 2024

I know it's not the case for tilling, but shouldn't the focus hint size be taken into account to calculate the gaps ?

Something like gaps = max(focus_hint, windows_gaps)

@git-f0x
Copy link
Contributor

git-f0x commented Apr 20, 2024

That would make sense aesthetically, but it might not be expected behavior to have gaps (e.g. if gaps are set to 0) because of the focus hint.

@wiiznokes
Copy link

wiiznokes commented Apr 20, 2024

That currently the case in the implementation. But gaps = windows_gaps + focus_hint should be considered. But it might take a lot of space in some case

@wiiznokes
Copy link

That currently the case in the implementation. But gaps = windows_gaps + focus_hunt should be considered. But it might take a lot of space in some case.

Edit: I see what you meant, if there is multiple windows, you will end up have gaps on non focused windows. The problem is that when the windows is on a edge on the screen, his focus hint get cropped

@git-f0x
Copy link
Contributor

git-f0x commented Apr 20, 2024

Well, in that case, setting so that the gap ≥ focus hint would resolve that (e.g. focus hint and gap set to 2). Anything else might lead to unexpected behavior for end users.
It could be restricted to not allow gap size to be lower than focus hint size, but not sure if something like that is desirable.

@ryanabx ryanabx force-pushed the feat/floating-maxim-etc branch 2 times, most recently from 5269731 to d8b1a75 Compare April 20, 2024 11:39
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants