-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: floating window tiling gaps #438
Conversation
9fad825
to
3824584
Compare
While I'm not certain, I don't think maximize should have gaps, since it should probably match the behavior from clicking the maximize button (it doesn't have gaps when maximized in auto tiling). |
Thanks for pointing that out to me! I never realized because I never maximize in tiling mode 😅 |
I know it's not the case for tilling, but shouldn't the focus hint size be taken into account to calculate the gaps ? Something like |
That would make sense aesthetically, but it might not be expected behavior to have gaps (e.g. if gaps are set to 0) because of the focus hint. |
That currently the case in the implementation. But |
That currently the case in the implementation. But Edit: I see what you meant, if there is multiple windows, you will end up have gaps on non focused windows. The problem is that when the windows is on a edge on the screen, his focus hint get cropped |
Well, in that case, setting so that the gap ≥ focus hint would resolve that (e.g. focus hint and gap set to 2). Anything else might lead to unexpected behavior for end users. |
5269731
to
d8b1a75
Compare
d8b1a75
to
455c0cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
2024-04-19.23-21-18.mp4
Friendly reminder tiling gaps can be configured in cosmic settings > appearance !