Add cosmic-screencopy-v2 based on current ext-screencopy proposal #24
Conversation
|
At some point we'll also want to switch this to make use of |
ids1024
force-pushed
the
ext-screencopy
branch
2 times, most recently
from
6d5cb8f
to
bf41b27
Compare
|
Added a commit with cosmic-client-toolkit helpers for this. Which is used in pop-os/xdg-desktop-portal-cosmic#31. The separate object for individual frames does seem a bit cleaner, and this implementation is more complete than the one that was previously here for v1. (But still missing handling for cursor sessions.) Still needs to be implemented in cosmic-workspaces. And hopefully some of the logic that both xdg-desktop-portal-cosmic and cosmic-workspaces duplicate could be moved into cosmic-client-toolkit. |
| pub struct Frame { | ||
| pub transform: WEnum<Transform>, | ||
| pub damage: Vec<Rect>, | ||
| // XXX monotonic? Is this used elsewhere in wayland? |
There was a problem hiding this comment.
Basically the same as presentation time protocol.
There was a problem hiding this comment.
Ah, right. So that's using Into<Duration>? Then we don't have a better type than Duration currently to represent this.
There was a problem hiding this comment.
In smithay this is using our own Clock- and Time-types from the utils module. Which happens to convert from a Duration. And no I don't think we have a better type in std.
| pub fn capture<D, U: ScreencopyFrameDataExt + Send + Sync + 'static>( | ||
| session: &zcosmic_screencopy_session_v2::ZcosmicScreencopySessionV2, | ||
| buffer: &wl_buffer::WlBuffer, | ||
| buffer_damage: &[Rect], |
There was a problem hiding this comment.
Maybe lets name that "additional_damage"? Or something? Normally you don't want to set anything here.
Drakulix
force-pushed
the
ext-screencopy
branch
from
bf41b27
to
8856ff2
Compare
(Also drops export-dmabuf.)
Draft until implemented everywhere