Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise dirty bytes to 256MB to fix btrfs performance #121

Merged
merged 1 commit into from Dec 22, 2021

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Dec 20, 2021

Closes #111

Check if a system with only magnetic storage copying large files across partitions/networks can do so successfully without stalling.

@mmstick mmstick requested review from a team December 20, 2021 12:08
@clintar
Copy link

clintar commented Dec 20, 2021

Tested this and it does fix my general freezing that I know to test. Thanks!

Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving a ~40GB file between btrfs partitions on spinner drives did not freeze or slow down. Seems to be working as expected.

@mmstick mmstick merged commit 3f0be51 into master_impish Dec 22, 2021
@mmstick mmstick deleted the dirty branch December 22, 2021 20:29
@fcgreg
Copy link

fcgreg commented Dec 24, 2021

I have done substantial performance testing with your patch so far, although I'm testing against flash/nvme primarily (no spinning media). Your patch has improved my btrfs performance significantly -- thank you. I'm using btrfs with 2 subvolumes (/root and /home) with LVM and an overall size of ~500GB.

ventureoo added a commit to ventureoo/CachyOS-Settings that referenced this pull request Aug 1, 2023
Optimal value that doesn't cause trashing on file systems with CoW

pop-os/default-settings#121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants