Fix Neofetch output to display Pop! instead of Ubuntu #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2019
markolo25
previously approved these changes
Apr 20, 2019
jackpot51
approved these changes
Apr 20, 2019
jackpot51
requested changes
Apr 20, 2019
|
The |
|
Are there other dpkg-diverts in other scripts |
Seems in 19.04, neofetch, and possibly others, are now readying from `/usr/lib/os-release` instead of `/etc/os-release`.
|
Yes, the |
|
Thanks, I am going to do some cleanup on this and then merge it |
jackpot51
approved these changes
Apr 22, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 19.04,
neofetchandlsb_release, and possibly others, are now reading from/usr/lib/os-releaseinstead of/etc/os-release. According to the freedesktop spec,/etc/os-releaseis supposed to take precedence over/usr/lib/os-release, and only fall back to/usr/lib/os-releaseif/etc/os-releaseis missing.lsb_releaseandneofetchseem to be exhibiting broken behavior in that regard.This will add a symlink at
/usr/lib/os-releaseso that applications using either/etc/os-releaseor/usr/lib/os-releasewill get the correct os-release.