Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gtk-rs 0.14, and use bind mappings #59

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Aug 19, 2021

Now "Show Dock on Display" and "Date & Time Notifications Position" show changes in response to changes from gsettings (for instance, dconf-editor). Otherwise behavior should be the same.

This changes Cargo.toml to use the "gtk-rs-0.14" branches of gtk-extras and theme-switcher. That should be changed back to master when those are merged.

Requires pop-os/theme-switcher#24 and pop-os/gtk-extras#3.

By using `bind` with mappings, "Show Dock on Display" and "Date & Time
Notifications Position" are changed in response to changes from
gsettings (with `dconf-editor`, etc.), for what that's worth.
@ids1024 ids1024 requested review from a team August 19, 2021 20:50
@jacobgkau
Copy link
Member

jacobgkau commented Aug 19, 2021

While testing this, I had a crash upon turning off Show Minimize Button for the first time (after toggling every setting before it on the page, from top to bottom); however, I was not running G-C-C from a terminal, and when I tried to recreate to see if there's any output, I'm having trouble getting it to happen again. This is the only mention of gnome-control-center in journalctl:

Aug 19 15:29:11 pop-os gnome-shell[2284]: Some code accessed the property 'ext' on the module 'extension'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Aug 19 15:29:14 pop-os gnome-shell[2284]: Couldn't find child [0x55781dfb6520 Gjs_ui_windowPreview_WindowPreview ("system76@pop-os: ~")] in window slots
Aug 19 15:29:14 pop-os gnome-shell[2284]: Couldn't find child [0x55781b4f24a0 Gjs_ui_windowPreview_WindowPreview ("Settings")] in window slots
Aug 19 15:29:14 pop-os gnome-shell[2284]: Couldn't find child [0x55781b4f6b30 Gjs_ui_windowPreview_WindowPreview ("gnome-shell")] in window slots
Aug 19 15:29:15 pop-os gnome-shell[2284]: Couldn't find child [0x55781dfb6520 Gjs_ui_windowPreview_WindowPreview:first-child ("system76@pop-os: ~")] in window slots
Aug 19 15:29:15 pop-os gnome-shell[2284]: Couldn't find child [0x55781b4f24a0 Gjs_ui_windowPreview_WindowPreview ("Settings")] in window slots
Aug 19 15:29:15 pop-os gnome-shell[2284]: Couldn't find child [0x55781b4f6b30 Gjs_ui_windowPreview_WindowPreview:last-child ("gnome-shell")] in window slots
Aug 19 15:29:30 pop-os kernel: gnome-control-c[17445]: segfault at ffffffffffffffd0 ip 00007fe1dc9585e9 sp 00007fff2a54b130 error 5 in libgtk-3.so.0.2404.21[7fe1dc6d7000+385000]
Aug 19 15:29:30 pop-os kernel: Code: 90 f3 0f 1e fa 41 56 41 55 41 89 f5 41 54 55 48 89 fd 53 4c 8b 67 20 e8 65 e1 09 00 49 8b 54 24 28 89 c3 48 63 05 cf 56 4a 00 <4c> 8b 34 02 49 8b 56 40 3b 5a 20 74 33 49 8d 7e 40 e8 11 dd e8 ff
Aug 19 15:29:33 pop-os systemd[1675]: app-gnome-gnome\x2dcontrol\x2dcenter-17445.scope: Succeeded.

@ids1024
Copy link
Member Author

ids1024 commented Aug 19, 2021

Weird. Don't see any issue here toggling both minimize and maximize a bunch of times.

It's hard to diagnose a segfault like that without running in a debugger and getting a backtrace.

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to recreate the segfault, so I'll have to assume it was caused by something else and disregard it.

All desktop-widget options still work with this update.

@ids1024 ids1024 merged commit 4152606 into master_hirsute Oct 13, 2021
@ids1024 ids1024 deleted the gtk-rs-0.14_hirsute branch October 13, 2021 20:55
@cappp cappp mentioned this pull request Oct 15, 2021
ids1024 added a commit that referenced this pull request Nov 19, 2021
Build was broken by a conflict here between
#58 and
#59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants