-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to gtk-rs 0.14, and use bind mappings #59
Conversation
By using `bind` with mappings, "Show Dock on Display" and "Date & Time Notifications Position" are changed in response to changes from gsettings (with `dconf-editor`, etc.), for what that's worth.
While testing this, I had a crash upon turning off
|
Weird. Don't see any issue here toggling both minimize and maximize a bunch of times. It's hard to diagnose a segfault like that without running in a debugger and getting a backtrace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been able to recreate the segfault, so I'll have to assume it was caused by something else and disregard it.
All desktop-widget options still work with this update.
Now "Show Dock on Display" and "Date & Time Notifications Position" show changes in response to changes from gsettings (for instance, dconf-editor). Otherwise behavior should be the same.
This changes
Cargo.toml
to use the"gtk-rs-0.14"
branches ofgtk-extras
andtheme-switcher
. That should be changed back to master when those are merged.Requires pop-os/theme-switcher#24 and pop-os/gtk-extras#3.