-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fstab pass value is set to 0 for all filesystems (including root) #312
Comments
@jacobgkau cool if I take this one? Might require some feedback |
@QuentinMoss totally! PRs are always welcome. Thanks for the interest! |
@leviport cool, thanks much. I'll start on this tonight. I was having some build issues to test my original changes on OS X, but I've installed ubuntu for this project so hopefully less friction |
Thanks for the contribution! The QA team has quite a bit on our plate right now, but we'll get to testing it as soon as we can. |
@leviport fix has been merged. |
Distribution (run
cat /etc/os-release
): Pop!_OS 22.04Related Application and/or Package Version (run
apt policy $PACKAGE NAME
):0.3.2~1663157572~22.04~d343ec3
Issue/Bug Description: In Pop!_OS, the final value for all lines in
/etc/fstab
is0
. This field controls the filesystem check (fsck) on boot. Ubuntu has the root partition defaulting to1
(and other partitions can be set to2
to be checked after the root partition.)It looks like this is set here: https://github.com/pop-os/distinst/blob/d343ec3444097afb76ebf9339a1cc736cafab1b2/crates/fstab-generate/src/block.rs
Steps to reproduce (if you know): Install Pop!_OS, check
/etc/fstab
.Expected behavior: Other distributions default to or recommend that the root partition have this field set to
1
so the root filesystem is checked on boot.Other Notes: A user in Mattermost asked about this, and I didn't have a good answer. I'm not sure if this default setting was intentional, but if it was, I couldn't find any previous issues, PRs, or chat conversations about it.
The only reason I can think of for skipping the filesystem check would be saving time on boot, but my understanding is that the check doesn't have to do much if there aren't any issues.
The text was updated successfully, but these errors were encountered: