fstab pass value is set to 0 for all filesystems (including root)

[jacobgkau]

Distribution (run cat /etc/os-release): Pop!_OS 22.04

Related Application and/or Package Version (run apt policy $PACKAGE NAME): 0.3.2~1663157572~22.04~d343ec3

Issue/Bug Description: In Pop!_OS, the final value for all lines in /etc/fstab is 0. This field controls the filesystem check (fsck) on boot. Ubuntu has the root partition defaulting to 1 (and other partitions can be set to 2 to be checked after the root partition.)

It looks like this is set here: https://github.com/pop-os/distinst/blob/d343ec3444097afb76ebf9339a1cc736cafab1b2/crates/fstab-generate/src/block.rs

Steps to reproduce (if you know): Install Pop!_OS, check /etc/fstab.

Expected behavior: Other distributions default to or recommend that the root partition have this field set to 1 so the root filesystem is checked on boot.

Other Notes: A user in Mattermost asked about this, and I didn't have a good answer. I'm not sure if this default setting was intentional, but if it was, I couldn't find any previous issues, PRs, or chat conversations about it.

The only reason I can think of for skipping the filesystem check would be saving time on boot, but my understanding is that the check doesn't have to do much if there aren't any issues.

[QuentinMoss]

@jacobgkau cool if I take this one? Might require some feedback

[leviport]

@QuentinMoss totally! PRs are always welcome. Thanks for the interest!

[QuentinMoss]

@leviport cool, thanks much. I'll start on this tonight. I was having some build issues to test my original changes on OS X, but I've installed ubuntu for this project so hopefully less friction

[QuentinMoss]

@leviport opened a PR here #315

[leviport]

Thanks for the contribution! The QA team has quite a bit on our plate right now, but we'll get to testing it as soon as we can.

[QuentinMoss]

@leviport fix has been merged.