Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System firmware does not need a progress bar #21

Closed
brs17 opened this issue Jul 31, 2019 · 4 comments
Closed

System firmware does not need a progress bar #21

brs17 opened this issue Jul 31, 2019 · 4 comments

Comments

@brs17
Copy link

brs17 commented Jul 31, 2019

With system firmware already downloaded before notifying the user of new firmware, the progress bar shown after selecting reboot shows up for a split second providing no real value to the user.

This progress bar c/should probably just be removed from system firmware updates.

@mmstick
Copy link
Member

mmstick commented Jul 31, 2019

Should we still display a progress bar when a device is being flashed, and system firmware is then clicked to schedule an update in the queue? Currently, devices are being flashed serially, so firmware will wait in line for their turn to be processed.

@brs17
Copy link
Author

brs17 commented Jul 31, 2019

Per discussion in person, we decided we will keep the progress bar but change the wording to "Waiting". With that change and fixing #22 it will look good.

The reason for the progress bar is for queuing multiple firmware updates (and preventing a reboot in the middle of a device firmware update).

@mmstick
Copy link
Member

mmstick commented Jul 31, 2019

That reminds me that we should activate a lock/suspend/reboot/shutdown inhibitor

@brs17
Copy link
Author

brs17 commented Aug 2, 2019

I think we're 90% there. I'm thinking we don't need the progress bar underneath Waiting as that progress bar never really progresses as once waiting is over the system reboots.

Screenshot from 2019-08-02 08-14-23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants