Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to A/C message should be smart about when to be displayed #23

Closed
brs17 opened this issue Jul 31, 2019 · 4 comments
Closed

Connect to A/C message should be smart about when to be displayed #23

brs17 opened this issue Jul 31, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@brs17
Copy link

brs17 commented Jul 31, 2019

Currently on all system firmware updates, there is a message at the bottom of the pop-up menu that tells the user if the machine they are on is a laptop, to plug in the laptop before running the update.

It should be possible to determine if the machine is a laptop or desktop and only show a message when the machine is a laptop.

@brs17 brs17 added the enhancement New feature or request label Jul 31, 2019
@brs17
Copy link
Author

brs17 commented Aug 1, 2019

  1. I think the message text could be shrunk from "If you're on a laptop, plug into power before you begin." to Plug into power before you begin since the message will only be shown on laptops.
  2. I am still getting the message on a thelio-major-r1. The output of upower -d is:
Device: /org/freedesktop/UPower/devices/DisplayDevice
  power supply:         no
  updated:              Thu 01 Aug 2019 03:30:28 PM MDT (184 seconds ago)
  has history:          no
  has statistics:       no
  unknown
    warning-level:       none
    icon-name:          'battery-missing-symbolic'

Daemon:
  daemon-version:  0.99.10
  on-battery:      no
  lid-is-closed:   no
  lid-is-present:  no
  critical-action: HybridSleep

@brs17 brs17 reopened this Aug 1, 2019
@mmstick
Copy link
Member

mmstick commented Aug 1, 2019

The latest commit should fix this

@brs17
Copy link
Author

brs17 commented Aug 2, 2019

With this logic implemented, the notification only appears when on a laptop that is running on battery. I am wondering if a message should show when on a laptop that is plugged in should say something along the lines of "Keep your laptop plugged in during this update". Thoughts @WatchMkr ?

@WatchMkr
Copy link
Collaborator

WatchMkr commented Aug 2, 2019

Let's stick with the plug in message if you're not plugged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants