-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exec, based on the branch from oknozor #19
base: main
Are you sure you want to change the base?
Conversation
Honestly I don't think moving the exec code into fde is such a great idea, because how we launch applications is a bit special especially regarding gpu code. If we still want to consider this crate to be somewhat generic, I think this should live in a separate library or possibly libcosmic. (The de-duplication of code is still very welcome). Additionally breaking the Also I don't believe the graphics code matches what we currently have in cosmic-launcher/app-library/app-list and that is a problem. This looks like a re-implementation of switcheroo, which gets a bunch of things wrong imo (e.g. hiding other gpus from applications instead of only setting the preferred one and messing with the ICDs). Plus we have plans to extend this logic in the future to make use of some cosmic-exclusive tricks. So I would really appreciate if we wouldn't modify the logic in the meantime and just use switcheroo like the current implementation does. |
Also, another constraint: the gnome-cosmic session still needs to be able to exec the desktop file itself. |
@Drakulix Hi, tbh, i didn't looked much in the GPU code of this PR yet, but from what i saw of in the launcher, most of it will have to get replaced. The launcher use
Indeed, this is still todo, but from what i understand, this use dbus to request some ids, and also set some env variables when launching the new process. I think it will fit well in this crate. Let me know if you think this will works. The problem of using libcosmic for this is that the service launcher doesn't depend on it. |
No description provided.