Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patches: disable 0027-window-Stop-using-HdyLeaflet.patch #103

Merged
merged 1 commit into from Jul 2, 2020

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Jul 1, 2020

Fixes #100.

See the description in the patch for the justification for patching this functionality out.

@ids1024 ids1024 requested a review from a team July 2, 2020 00:22
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to cause any problems. A few observations:

  • Some pages still have a higher minimum width than other pages. The most noticeable is "Mouse & Touchpad," which seems to want more padding on either side of the actual content than most of the other pages. However, this is also the case when the patch is applied, so that's not a regression.

  • If I launch Settings and make it smaller without clicking anything, the window collapses to the list of pages. If I launch Settings and click on the already-selected page's label and then make the window smaller, it collapses to the selected page. This seems like intentional behavior.

  • If I shrink the window to single-column view and select one of the wider pages (such as Mouse & Touchpad), then use the top-left arrow to go back to the list of pages, the list uses the minimum width of the last-selected page. (I.e., the list won't get any skinnier until I select a skinnier page and then go back to the list.) This seems to be because the last-selected page, while not indicated visually in the single-column list, is still saved so it shows up when the window is made wide enough for two columns again.

Also tested with Pop Shell. Opened pop-os/shell#446 and pop-os/shell#447 for two issues I discovered that are not regressions (also happen with the patch applied.)

@ids1024
Copy link
Member Author

ids1024 commented Jul 2, 2020

Some pages still have a higher minimum width than other pages. The most noticeable is "Mouse & Touchpad," which seems to want more padding on either side of the actual content than most of the other pages. However, this is also the case when the patch is applied, so that's not a regression.

Interesting. This seems to happen with my slightly modified build from upstream master, so it seems to be an upstream issue, and as you say, also not a regression.

I guess it doesn't have more problems than already existed, and while the Ubuntu maintainer is right that this is "less useful in the desktop case", I suppose this is more useful with tiling. So I'll merge it.

@ids1024 ids1024 merged commit f932311 into master_focal Jul 2, 2020
@jackpot51 jackpot51 deleted the re-enable-hdyleaflet_focal branch July 2, 2020 18:17
@ids1024
Copy link
Member Author

ids1024 commented Jul 2, 2020

The most noticeable is "Mouse & Touchpad," which seems to want more padding on either side of the actual content than most of the other pages.

I've tracked down the cause of this, though I'm not sure exactly what the best solution is: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customization in G-C-C Limits Shrinking to a Single Column
3 participants