feat(desktop): Set sidebar to visible child #187
Conversation
This commit includes all the changes that seem to be necessary for CcKeyboardItem to be used for dealing with multiple keybindings, without (yet) changing the user interface to expose this. The `primary_combo` and `binding` fields of `CcKeyboardItem` are removed, in favor of the existing `key_combos`. No combination is "primary", since all of them can now be seen and changed equally. We treat `CcKeyboardItem.key_combos` as a set, that a combo can be added to or removed from. Though it continues to be represented as a `GList`, instead of a `GHashTable`, to preserve ordering. A lot of the keyboard panel code relied on the assumption that only one combo can be set for each setting, so this required a variety of miscellaneous changes.
This adds a widget called `CcKeyboardShortcutRow`, sub-classing `GtkListBoxRow`, to handle a shortcut row. This makes the implementation a bit tidier, rather than handling it all in `CcKeyboardPanel`, and allows the widgets that compose the row to be laid out in xml. This is a prerequisite for moving the shortcuts to a new dialog.
For some reason, the ungrab was making the window impossible to interact with. Without these calls, it seems to work as expected.
Previously, there were multiple redundant lists of possible values for this setting. This uses one struct to define not only all the possible values, but also anything specific to the alternate characters key, so this can be used for other modifiers. This also changes the style of the dialog to use a GtkListBox.
This was previously available only in Gnome Tweaks.
Implementation borrowed from cc-search-panel-row.c
Coppied from 426adb3
Copied and pasted older shortcut dialog and row, then fixed issues. May have some problems.
Not doing much good.
This seems to avoid frezing. I think this was meant for symmetry with grab_seat()... let's see if this works as expected.
Was printing assertion failure
groovy: Fix pop-hidpi.patch to not crash when hidpi-daemon is not installed
groovy: Add a patch for CcSearchLocationsDialog issue
I tried to just hide the panel, but `CC_PANEL_HIDDEN` seems to prevent it from opening even from the command line. #165
|
@mmstick It looks like this PR only fixes one sub-panel (Backgrounds) in the Desktop settings. From what I understand #174 wouldn't be closed as it refers to "Dock" directly and all other sub-panels indirectly. It does fix pop-os/beta#152, but I'm not sure if that is intended. |
|
@bflanagin Not sure if this is what you mean, but I see that searching within Settings, all five sub-pages return
Search for the Launcher should be fixed with pop-os/desktop-widget#31 once it's fixed, but I don't think that will help for the search within Settings. Regarding pop-os/beta#152, if I already have another desktop-widget page selected (like Dock), then |
|
This and the other PR make the panels searchable in the launcher. It wouldn't yet work inside settings itself. |
|
From the launcher Mostly working: Background Notes: Using the keywords: desktop,screens,wallpaper in the launcher displays Desktop (linked to Background), which is desirable if a little confusing, where as the keyword "background" displays all available options in the Desktop settings widget, instead of just the Background and possibly Desktop items. Screenshot for reference: Also there is a small disconnect between using the word Cosmic to get to the Desktop->General view when we call the section "Desktop" in GCC. This is made even more confusing in conjunction with how the launcher displays "Desktop" (which goes to Backgrounds) when you search for Workspaces,or Dock and not Cosmic. I imagine removing the Desktop option from the search results will fix the latter, but I'm not sure what the best option is for the former. Would it be against the grain to change the top level menu item from Desktop to Cosmic? |
|
We can change Desktop, but that would be in gnome-control-center, since that is where that desktop entry presides. |
|
I'm cool with keeping it Cosmic for now if it makes merging this PR easier. The only thing that really stands out as "unintended behavior" is the background keyword displaying every option (as mentioned above.) |
|
Looking at the code here and in https://github.com/pop-os/desktop-widget/pull/31/files I realize the issue with the "background" keyword isn't directly connected with either PR and have created an issue for it. I'll create an issue about the naming miss match as well. |
|
I believe this is superseded by #210. Closing. |
Closes #174