Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong menubar text color on Skype with default theme #230

Closed
wesbluemarine opened this issue Oct 27, 2018 · 2 comments
Closed

Wrong menubar text color on Skype with default theme #230

wesbluemarine opened this issue Oct 27, 2018 · 2 comments

Comments

@wesbluemarine
Copy link

screenshot from 2018-10-27 18-14-22
Distribution (run cat /etc/os-release):
NAME="Pop!_OS"
VERSION="18.10"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Pop!_OS 18.10"
VERSION_ID="18.10"
HOME_URL="https://system76.com/pop"
SUPPORT_URL="http://support.system76.com"
BUG_REPORT_URL="https://github.com/pop-os/pop/issues"
PRIVACY_POLICY_URL="https://system76.com/privacy"
VERSION_CODENAME=cosmic
UBUNTU_CODENAME=cosmic

Gtk+ 3.0 version - (run apt policy libgtk-3-0):
libgtk-3-0:
Installed: 3.24.1-1ubuntu2
Candidate: 3.24.1-1ubuntu2
Version table:
*** 3.24.1-1ubuntu2 500
500 http://us.archive.ubuntu.com/ubuntu cosmic/main amd64 Packages
100 /var/lib/dpkg/status

Desktop environment:
GNOME 3.30.1

Pop version (run head -n 3 /usr/share/themes/Pop/gtk-3.22/gtk.css):

  • Pop!_OS gtk-widgets Theme (The Pop!_GTK Theme) Version 4.0.0
  • Copyright 2017-2018 System76, Inc.

Related Application and/or Shell theming (or name of widget)
Skype with default pop theme

Actual issue
Menubar text color is too dark

Expected behavior
Menubar text color should be light

Behavior in Adwaita
Adwaita dark has light text

Other Note (feature-request, question, etc...)
Change menubar text color with a lighter one.

@isantop
Copy link
Contributor

isantop commented Dec 6, 2018

This appears to be caused by a new Electron bug where they get the color of the menu bar from GtkMenuBar, but the color for the text from the context menu text color. In themes where the menu bar is light-text on dark and context menus are dark-text on light, (like Yaru, Adapta, Materia, Arc-Darker, Pop) this issue will occur.

Upstream Electron bug: electron/electron#15194

@isantop
Copy link
Contributor

isantop commented Oct 23, 2019

Closing this issue as electron has been updated to correct this issue.

@isantop isantop closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants