Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .titlebar class for headerbars #43

Closed
cassidyjames opened this issue Oct 5, 2017 · 2 comments · Fixed by #48
Closed

Support .titlebar class for headerbars #43

cassidyjames opened this issue Oct 5, 2017 · 2 comments · Fixed by #48
Labels

Comments

@cassidyjames
Copy link
Contributor

It's a convention in elementary and AppCenter apps to use a .titlebar class on the headerbar to be able to reduce the padding and make it look like a normal titlebar while still packing in some buttons. elementary Terminal, for example, uses this for its search and font-size buttons.

Something like this would support that convention:

headerbar.titlebar {
	padding-top: 0;
	padding-bottom: 0;
}

headerbar.titlebar button {
	margin-top: 0;
	margin-bottom: 0; 
}

That takes elementary Terminal in Pop!_OS from this:

screenshot from 2017-10-04 22-14-54

...to this:

screenshot from 2017-10-04 22-15-10

...which is more how it's designed to look.

@cassidyjames
Copy link
Contributor Author

Re-opening this since the previous fix broke other things and has been reverted.

@cassidyjames cassidyjames reopened this Oct 7, 2017
@isantop
Copy link
Contributor

isantop commented Oct 10, 2017

Re-fixed in 9498c5f

@isantop isantop closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants