Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gnome-terminal default (light) theme #53

Closed
WatchMkr opened this issue Oct 10, 2017 · 4 comments
Closed

Improve gnome-terminal default (light) theme #53

WatchMkr opened this issue Oct 10, 2017 · 4 comments

Comments

@WatchMkr
Copy link
Contributor

Change tabs to match
Change sidebar to fit in
@isantop
Copy link
Contributor

isantop commented Oct 10, 2017 •
edited
Loading

Is this the same issue issue #40 ? If so, I think this is better solved by setting GNOME Terminal to use the dark theme by default since "fixing" that would be hacking the light theme to use the dark theme styling for GNOME Terminal.

@WatchMkr
Copy link
Contributor Author

The dark theme header bar is too dark and menu's don't match with the rest of the desktop.

The terminal is important enough that investing in getting the light variant correct is worth it.

@isantop
Copy link
Contributor

isantop commented Oct 10, 2017

Relevant screenshots in Adwaita and Adapta

screenshot from 2017-10-10 10-19-37

screenshot from 2017-10-10 10-19-21

@isantop
Copy link
Contributor

isantop commented Oct 11, 2017

Fixed in 38d4307

@isantop isantop closed this as completed Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WatchMkr @isantop