Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling Improvements for Fullcolor Icons #125

Merged
merged 13 commits into from
Aug 17, 2022

Conversation

isantop
Copy link
Contributor

@isantop isantop commented Aug 5, 2022

Improves the tooling for rendering fullcolor icons:

  • Changes the name of "bitmap" to "fullcolor" to reflect that these are no longer bitmaps
  • Allows the script to automatically render updated icon files without deleting the source file first
  • Reduces unnecessary information in the command output

Additionally, this removes the "Panel" icons which aren't currently rendered or included in the theme; most DEs now use real symbolic icons for use in panels, so these are no longer necessary.

* Automatically render modified source icons
* Improve command output to add more information without clutter
* Reduce unnecessary output to reduce clutter
We don't render these, they don't need to be there. Pretty much every panel
icon is just a symbolic anyway, and these aren't included in the final theme
output.
@isantop isantop marked this pull request as draft August 5, 2022 19:34
@isantop isantop marked this pull request as ready for review August 8, 2022 20:09
@isantop isantop requested review from a team August 8, 2022 20:09
@isantop isantop self-assigned this Aug 8, 2022
@isantop isantop added the enhancement New feature or request label Aug 8, 2022
@isantop isantop removed request for a team August 8, 2022 20:10
@isantop isantop marked this pull request as draft August 8, 2022 20:10
@isantop
Copy link
Contributor Author

isantop commented Aug 8, 2022

I had forgotten about my updated Documentation goals on this PR, please disregard for now. Sorry about the notifications

These aren't actually bitmaps anymore, so we should just call them fullcolor
@isantop isantop force-pushed the fullcolor-improvements-tooling branch from df5b013 to c3488fd Compare August 8, 2022 20:44
@isantop isantop force-pushed the fullcolor-improvements-tooling branch from 2cb8b91 to eba8379 Compare August 8, 2022 21:52
@isantop isantop marked this pull request as ready for review August 8, 2022 22:44
@isantop isantop requested review from a team August 8, 2022 22:44
@isantop
Copy link
Contributor Author

isantop commented Aug 8, 2022

Documentation changes are complete, should be gtg

@leviport leviport merged commit 4267d58 into master Aug 17, 2022
@leviport leviport deleted the fullcolor-improvements-tooling branch August 17, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants