Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Icons: VPN Disabled and VPN No-Route #126

Merged
merged 3 commits into from
Aug 19, 2022
Merged

New Icons: VPN Disabled and VPN No-Route #126

merged 3 commits into from
Aug 19, 2022

Conversation

isantop
Copy link
Contributor

@isantop isantop commented Aug 10, 2022

Adds icons for vpn-disabled and vpn-no-route to he symbolic icon set. The metaphors used follow other icons for -no-route and -disabled for UX consistency.

image

Fixes #121

@isantop isantop self-assigned this Aug 10, 2022
Copy link
Contributor

@13r0ck 13r0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 thanks!

@isantop isantop marked this pull request as ready for review August 19, 2022 19:23
@n3m0-22 n3m0-22 self-assigned this Aug 19, 2022
@n3m0-22 n3m0-22 requested a review from a team August 19, 2022 20:09
Copy link
Contributor

@n3m0-22 n3m0-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Example:

Screenshot from 2022-08-19 13-49-52

@isantop isantop merged commit c64e514 into master Aug 19, 2022
@isantop isantop deleted the vpn-off branch August 19, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN icon when VPN is off looks very similar to the icon when VPN is on.
3 participants