Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform user if qalc or fdfind isn't installed #36

Merged
merged 2 commits into from Oct 7, 2021
Merged

Inform user if qalc or fdfind isn't installed #36

merged 2 commits into from Oct 7, 2021

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Oct 6, 2021

  • If attempting to use the calc plugin without qalc installed, the search result will be a message stating that it isn't installed.
  • Does the same for the find plugin with fdfind

Closes #30

@mmstick mmstick requested review from a team October 6, 2021 15:15
@jacobgkau
Copy link
Member

jacobgkau commented Oct 6, 2021

This is working for qalc. For fdfind, I'm seeing app search results if I type find without it installed, and once I type a space, the results seem to get stuck:

Screencast.from.10-06-2021.05.14.36.PM.mp4

journalctl is showing pop_launcher_plugsin::find: failed to spawn fdfind process: No such file or directory. I don't see anything like that when I get the qalc command is not installed message.

@mmstick
Copy link
Member Author

mmstick commented Oct 7, 2021

It was missing a "Finished" message. Fixed.

@jacobgkau
Copy link
Member

This PR is touching the terminal plugin, was it supposed to include 6cdf298? (Can we rebase now that #34 is merged? I was checking because I didn't want that to get undone.)

@mmstick
Copy link
Member Author

mmstick commented Oct 7, 2021

I can rebase

@jacobgkau
Copy link
Member

jacobgkau commented Oct 7, 2021

I'm no longer getting the freeze, but not getting any message about fdfind not being installed:

Peek 2021-10-07 10-31

The qalc message is still working.

@mmstick
Copy link
Member Author

mmstick commented Oct 7, 2021

Forgot to .await the sending of the message.

@jacobgkau
Copy link
Member

jacobgkau commented Oct 7, 2021

Working now! Is there a reason we say qalc command is not installed for qalc but only fdfind is not installed for fdfind? From what I can tell, both are commands. (In Ubuntu, qalc is actually the name of the qalc package, where fdfind's package is actually fd-find.)

@mmstick
Copy link
Member Author

mmstick commented Oct 7, 2021

I can fix the wording of the message.

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, both plugins are working properly and displaying the message when needed on both 21.04 and 20.04.

@mmstick mmstick merged commit 55c1b6e into master Oct 7, 2021
@jackpot51 jackpot51 deleted the not-found branch October 7, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculator plugin should display error when qalc is not installed
3 participants