fix(terminal): resolve terminal symlink once #34
Conversation
| return (found, "-e"); | ||
| } |
There was a problem hiding this comment.
Should be this instead:
return (read_link(&found).unwrap_or(found), "-e");There was a problem hiding this comment.
Just updated, but I don't understand why we need to attempt resolving the symlink twice here ?
There was a problem hiding this comment.
That's just how Debian systems have this symlink configured, because of their use of /etc/alternatives. /usr/bin/x-terminal-emulator is a symlink to /etc/alternatives/x-terminal-emulator, which is a symlink to whichever binary was designated as the alternative option for that.
There was a problem hiding this comment.
GNOME Terminal still launches with the default /usr/bin/x-terminal-emulator -> /etc/alternatives/x-terminal-emulator -> /usr/bin/gnome-terminal.wrapper symlinks in place. Changing either /usr/bin/x-terminal-emulator to point directly to a different terminal, or /etc/alternatives/x-terminal-emulator to point to a different terminal, both work. Tested on Pop!_OS 21.04 and 20.04, with all three prefixes for this plugin.
closes #33