Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies #87

Merged
merged 4 commits into from Mar 1, 2022
Merged

chore: Update dependencies #87

merged 4 commits into from Mar 1, 2022

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Feb 28, 2022

No description provided.

@mmstick mmstick requested review from a team February 28, 2022 17:07
jackpot51
jackpot51 previously approved these changes Feb 28, 2022
@jacobgkau
Copy link
Member

This seems to build locally, but failed to build for all releases on the build server:

Output:
�[1mlauncher: 6bd9b7aa4659bfb570f181d7aa03de6f1484f1c5 (launcher): impish (21.10): source github status pending�[0m
 dpkg-buildpackage -d -us -uc -ui -S
dpkg-buildpackage: info: source package pop-launcher
dpkg-buildpackage: info: source version 1.1.0~1646067958~21.10~6bd9b7a
dpkg-buildpackage: info: source distribution impish
dpkg-buildpackage: info: source changed by Pop OS (ISO Signing Key) <info@system76.com>
 dpkg-source --before-build .
 fakeroot debian/rules clean
dh clean --with=systemd
   debian/rules override_dh_auto_clean
make[1]: Entering directory '/home/jenkins/workspace/pop-os/repos/_build/ci/git/launcher/6bd9b7aa4659bfb570f181d7aa03de6f1484f1c5/impish/partial.source/archive'
ischroot && make clean || make distclean
make[2]: Entering directory '/home/jenkins/workspace/pop-os/repos/_build/ci/git/launcher/6bd9b7aa4659bfb570f181d7aa03de6f1484f1c5/impish/partial.source/archive'
rm -rf .cargo vendor vendor.tar target
make[2]: Leaving directory '/home/jenkins/workspace/pop-os/repos/_build/ci/git/launcher/6bd9b7aa4659bfb570f181d7aa03de6f1484f1c5/impish/partial.source/archive'
ischroot || make vendor
make[2]: Entering directory '/home/jenkins/workspace/pop-os/repos/_build/ci/git/launcher/6bd9b7aa4659bfb570f181d7aa03de6f1484f1c5/impish/partial.source/archive'
mkdir -p .cargo
cargo vendor --sync plugins/Cargo.toml | head -n -1 > .cargo/config
error: failed to sync

Caused by:
  failed to download packages

Caused by:
  failed to download `atk v0.15.1`

Caused by:
  unable to get packages from source

Caused by:
  failed to parse manifest at `/home/jenkins/.cargo/registry/src/github.com-1ecc6299db9ec823/atk-0.15.1/Cargo.toml`

Caused by:
  feature `edition2021` is required

  consider adding `cargo-features = ["edition2021"]` to the manifest
echo 'directory = "vendor"' >> .cargo/config
tar pcf vendor.tar vendor
rm -rf vendor

@mmstick
Copy link
Member Author

mmstick commented Feb 28, 2022

Sounds like the build server has an older version of Rust installed. Maybe it needs an update?

@jackpot51
Copy link
Member

@mmstick if you need a specific version, please add a rust-toolchain file.

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this change, selecting open windows (with Enter or click) no longer works. If I'm trying to select the window that's highlighted, then its highlight goes away, but that's it. The window is not focused and the launcher does not close. (Opening new apps appears to be unaffected.)

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed a .desktop file in /usr/local/share/applications/ shows up now.

Launcher regression testing passed:
launcher-pr87-impish.txt
launcher-pr87-focal.txt

@mmstick mmstick merged commit 21f699e into master Mar 1, 2022
@mmstick mmstick deleted the launcher branch March 1, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants