fix(theme): light theme surface lightness is inverted #407
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Figma, themes with background lightness above 88 have their surfaces darkened; whereas below 88 have their surfaces lightened. This fixes custom light theme surfaces being unusually dark against a darker background.
wash2
approved these changes
Apr 22, 2024
|
I'll quick release a cosmic-settings update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, light themes are getting darker surfaces when the background lightness is below 89. In Figma, themes with background lightness above 88 have their surfaces darkened; whereas below 88 have their surfaces lightened. This fixes custom light theme surfaces being unusually dark against a darker background. Some comparisons below using color schemes from Figma
Figma
Before
After