[feat] set default color palette based on user preference #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmstick
approved these changes
Apr 26, 2024
bbb651
reviewed
May 12, 2024
| let current_desktop = std::env::var("XDG_CURRENT_DESKTOP"); | ||
|
|
||
| if let Ok(desktop) = current_desktop { | ||
| if desktop.trim().to_lowercase().contains("gnome") { |
There was a problem hiding this comment.
This value would never be anything other than exactly GNOME on GNOME, this seems a bit error prone and unnecessary, the best list I could find of possible values in on this page on the arch wiki. This code only runs when xdg-portal is disabled right?
There was a problem hiding this comment.
I guess it does match GNOME-Flashback which it probably should, I've never heard of it before, I guess it's very unlikely a desktop name would contain "gnome", but with other desktops like "kde" it's more likely to have collisions
There was a problem hiding this comment.
yeah maybe you are right. However pop-os return different value:
~ ❯ echo $XDG_CURRENT_DESKTOP
pop:GNOME
so it's in case some distros have this value set to something else than GNOME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Today tried libcosmic on Pop_OS with current Gnome implementation. The problem was with preferred color palette in libcosmic apps. I'm using light theme in my OS and apps was started always as dark theme. Before I was added these feature to my app when using Iced and it was working so considered to add this to libcosmic. I'm not sure if you want to see such features. The implementation is very simple based on
gsettingsapp andcolor-schemevalue. From my tests on pop os it's working. It should work everywhere where gsettings are installed, otherwise it will default to dark theme as before so nothing lost here :) Would be nice to see it implemented.