Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System76 pang12 audio support #205

Merged
merged 2 commits into from
Jan 19, 2023
Merged

System76 pang12 audio support #205

merged 2 commits into from
Jan 19, 2023

Conversation

jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Jan 14, 2023

Enables internal mic, but I'll need to find a quirk for the combo jack to show a prompt

@jackpot51 jackpot51 self-assigned this Jan 14, 2023
@jackpot51 jackpot51 marked this pull request as ready for review January 18, 2023 23:10
@jackpot51 jackpot51 changed the title Add quirk to enable ACP DMIC on System76 pang12 System76 pang12 audio support Jan 18, 2023
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very close, but I can still break it with a specific sequence of events: #220

Since this sequence of events seems like a pretty unlikely one, and the overall impact of it happening is very low (user just has to unplug and re-plug the headphones, or change back to the built-in mic in sound settings), I am approving after opening #220 to track that last little remnant of the combo jack bug.

@leviport leviport requested a review from a team January 19, 2023 01:06
@jackpot51 jackpot51 merged commit ca93ccf into master Jan 19, 2023
@jackpot51 jackpot51 deleted the pang12_jammy branch January 19, 2023 14:48
@leviport leviport mentioned this pull request Mar 3, 2023
@Atreyagaurav
Copy link

Atreyagaurav commented Apr 5, 2023

Hi, is there any plans to send it to upstream? I'm using Arch Linux (6.2.9-arch1) on pang12 model and my audio (mic) doesn't work. It does seem to work when I tried a live boot of PopOS. Fix on Linux Kernel would be nice.

@WingofaGriffin
Copy link

@jackpot51 agreeing with above, is this being pushed to upstream? Mic is confirmed not to work on vanilla kernel.

@leviport
Copy link
Member

It was upstreamed. It takes time for changes like that to propagate back downstream.

@crawfxrd
Copy link
Member

Specifically, the DMI entry has been upstreamed. It is currently in the for-next branch: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?id=7b9891ad25246b18b5ccc19518da7abc7763aa0a

I did not submit the duplicated codec entry.

@Atreyagaurav
Copy link

@WingofaGriffin: have you tested the new kernel? In 6.3.4-arch1-1 (Arch Linux) the Mic is shown in the pulseaudio finally, but it still doesn't take any inputs. No recording activity.

@WingofaGriffin
Copy link

I indeed still do not seem to be getting any inputs or recording activity.

@Atreyagaurav
Copy link

That makes sense, when I looked further the Mic that's shown seems to be for headphone jack (as it says unplugged) not internal mic.

Pulseaudio Screenshot:

image

@Atreyagaurav
Copy link

Atreyagaurav commented Jun 22, 2023

Update, the mic can be seen from the Pulseaudio control now:

There is no "Base" like in others, but it seems to be working.

image

EDIT: I'm on 6.3.8-arch1-1, it could have been fixed earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants