Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 6.4.11 jammy #276

Merged
merged 0 commits into from
Aug 30, 2023
Merged

Linux 6.4.11 jammy #276

merged 0 commits into from
Aug 30, 2023

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Aug 21, 2023 •
edited
Loading

Supersedes #273

Due to a conflict, I've dropped this revert commit: #193
The source of the issue may have been fixed by the changes causing the conflict.
If we still need to revert this change, I'll make a new patch.

@mmstick mmstick requested review from a team August 21, 2023 17:52
@leviport
Copy link
Member

I checked SD cards on pang11 since that commit was dropped and this does break it, so we will need that patch.

@leviport
Copy link
Member

That patch fixed the SD card slot on pang11, so that's looking good now

jackpot51
jackpot51 previously approved these changes Aug 22, 2023
View reviewed changes
@XV-02
Copy link

XV-02 commented Aug 22, 2023

Virtualbox is failing to install. the DKMS module is failing to build during install.

@leviport
Copy link
Member

Even with the vb branch added? Should bring in pop-os/virtualbox#10 and pop-os/virtualbox-ext-pack#3, as long as they're not stuck in CI

@XV-02
Copy link

XV-02 commented Aug 22, 2023

Even with the vb branch added? Should bring in pop-os/virtualbox#10 and pop-os/virtualbox-ext-pack#3, as long as they're not stuck in CI

Yep. Looks like Jacob clocked it as not unblocking 6.4.10 as well in the virtualbox PR as well. 😞

@mmstick
Copy link
Member Author

mmstick commented Aug 23, 2023

I pushed a commit to our vb_jammy PR that fixes compilation here.

@XV-02
Copy link

XV-02 commented Aug 23, 2023

We'll need to make sure to incorporate our fix for raptor lake c-states. RPL is only hitting C6 with this kernel, but hits C8 with the fix.

@XV-02
Copy link

XV-02 commented Aug 30, 2023

Everything is looking good.

  • Updating to new kernel works with apt update && apt upgrade
    • No new dependencies are required for kernel update
  • system76-power still operates as expected (across Intel/NVIDIA/switchable machines)
  • Mic in
  • Audio out:
    • Laptop's built-in speakers
    • Headphones
    • DisplayPort
    • HDMI
  • Video out via:
    • DisplayPort
      • Daisy-chain over DP
    • HDMI
  • Thunderbolt docking station:
    • HDMI and DisplayPort
    • External storage device
    • Networking
  • Suspend and resume:
    • Suspend and resume works with a bluetooth device paired
    • Switchable graphics laptops
      • In Hybrid graphics mode
      • In Nvidia graphics mode
      • In Integrated graphics mode
    • Nvidia desktop
      • Current Nvidia driver works (i.e. 535)
      • Legacy Nvidia driver works (i.e. 470)
      • Plymouth decrypt prompt appears as expected on multiple machines (mira-r2 and mega-r2 are good examples)
    • Discrete AMD desktop
    • Integrated Intel desktop
    • Integrated AMD desktop
    • 150 suspend/resume cycles (fwts s3 --s3-multiple 150)
  • Graphics drivers included in the kernel (Intel/AMD)
    • Switchable/hybrid graphics and graphics switching
  • Steam
    • Steam installs via the Pop!_OS .deb in Pop!_Shop
    • Steam launches from launcher
    • Linux native game installs and runs
    • Proton game installs and runs
  • VirtualBox installs and works as expected
    • virtualbox-ext-pack installs as expected
  • Broadcom wireless driver (bcmwl-kernel-source) installs without DKMS errors
  • On Dev One, fan speed is shown in sensors
  • All of our maintained DKMS packages are installable:
    • NVIDIA
    • ZFS
    • System76
    • hp-vendor

@mmstick mmstick merged commit 9b709c7 into master Aug 30, 2023
4 checks passed
This was referenced Aug 31, 2023
Open
Closed
mmstick pushed a commit that referenced this pull request Jan 8, 2024
@rostedt @gregkh
tracing / synthetic: Disable events after testing in synth_event_gen_…
7e39c55 
…test_init()

commit 88b30c7 upstream.

The synth_event_gen_test module can be built in, if someone wants to run
the tests at boot up and not have to load them.

The synth_event_gen_test_init() function creates and enables the synthetic
events and runs its tests.

The synth_event_gen_test_exit() disables the events it created and
destroys the events.

If the module is builtin, the events are never disabled. The issue is, the
events should be disable after the tests are run. This could be an issue
if the rest of the boot up tests are enabled, as they expect the events to
be in a known state before testing. That known state happens to be
disabled.

When CONFIG_SYNTH_EVENT_GEN_TEST=y and CONFIG_EVENT_TRACE_STARTUP_TEST=y
a warning will trigger:

 Running tests on trace events:
 Testing event create_synth_test:
 Enabled event during self test!
 ------------[ cut here ]------------
 WARNING: CPU: 2 PID: 1 at kernel/trace/trace_events.c:4150 event_trace_self_tests+0x1c2/0x480
 Modules linked in:
 CPU: 2 PID: 1 Comm: swapper/0 Not tainted 6.7.0-rc2-test-00031-gb803d7c664d5-dirty #276
 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
 RIP: 0010:event_trace_self_tests+0x1c2/0x480
 Code: bb e8 a2 ab 5d fc 48 8d 7b 48 e8 f9 3d 99 fc 48 8b 73 48 40 f6 c6 01 0f 84 d6 fe ff ff 48 c7 c7 20 b6 ad bb e8 7f ab 5d fc 90 <0f> 0b 90 48 89 df e8 d3 3d 99 fc 48 8b 1b 4c 39 f3 0f 85 2c ff ff
 RSP: 0000:ffffc9000001fdc0 EFLAGS: 00010246
 RAX: 0000000000000029 RBX: ffff88810399ca80 RCX: 0000000000000000
 RDX: 0000000000000000 RSI: ffffffffb9f19478 RDI: ffff88823c734e64
 RBP: ffff88810399f300 R08: 0000000000000000 R09: fffffbfff79eb32a
 R10: ffffffffbcf59957 R11: 0000000000000001 R12: ffff888104068090
 R13: ffffffffbc89f0a0 R14: ffffffffbc8a0f08 R15: 0000000000000078
 FS:  0000000000000000(0000) GS:ffff88823c700000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 0000000000000000 CR3: 00000001f6282001 CR4: 0000000000170ef0
 Call Trace:
  <TASK>
  ? __warn+0xa5/0x200
  ? event_trace_self_tests+0x1c2/0x480
  ? report_bug+0x1f6/0x220
  ? handle_bug+0x6f/0x90
  ? exc_invalid_op+0x17/0x50
  ? asm_exc_invalid_op+0x1a/0x20
  ? tracer_preempt_on+0x78/0x1c0
  ? event_trace_self_tests+0x1c2/0x480
  ? __pfx_event_trace_self_tests_init+0x10/0x10
  event_trace_self_tests_init+0x27/0xe0
  do_one_initcall+0xd6/0x3c0
  ? __pfx_do_one_initcall+0x10/0x10
  ? kasan_set_track+0x25/0x30
  ? rcu_is_watching+0x38/0x60
  kernel_init_freeable+0x324/0x450
  ? __pfx_kernel_init+0x10/0x10
  kernel_init+0x1f/0x1e0
  ? _raw_spin_unlock_irq+0x33/0x50
  ret_from_fork+0x34/0x60
  ? __pfx_kernel_init+0x10/0x10
  ret_from_fork_asm+0x1b/0x30
  </TASK>

This is because the synth_event_gen_test_init() left the synthetic events
that it created enabled. By having it disable them after testing, the
other selftests will run fine.

Link: https://lore.kernel.org/linux-trace-kernel/20231220111525.2f0f49b0@gandalf.local.home

Cc: stable@vger.kernel.org
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Tom Zanussi <zanussi@kernel.org>
Fixes: 9fe41ef ("tracing: Add synth event generation test module")
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Reported-by: Alexander Graf <graf@amazon.com>
Tested-by: Alexander Graf <graf@amazon.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawfxrd crawfxrd crawfxrd approved these changes

@XV-02 XV-02 XV-02 approved these changes

@jackpot51 jackpot51 jackpot51 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmstick @leviport @XV-02 @crawfxrd @jackpot51