Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK App Fixes #29

Merged
merged 9 commits into from Mar 26, 2018
Merged

GTK App Fixes #29

merged 9 commits into from Mar 26, 2018

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Mar 26, 2018

@mmstick mmstick changed the title [WIP] GTK App Fixes GTK App Fixes Mar 26, 2018
@jackpot51 jackpot51 self-requested a review March 26, 2018 14:49
@jackpot51
Copy link
Member

jackpot51 commented Mar 26, 2018

I think at line 314 in gtk/src/app/state.rs, the device list is not filtered based on the checkbutton. Is that true?

EDIT: I fixed this here: 10faca1

@jackpot51
Copy link
Member

The hash gets truncated now that that Hash: label is before the dropdown. Perhaps we should increase the minimum size of the window?

@mmstick
Copy link
Member Author

mmstick commented Mar 26, 2018

Yeah, it should default to a size that fits the complete hash.

@mmstick
Copy link
Member Author

mmstick commented Mar 26, 2018

Unsure on how to set a minimum size at the moment.

@jackpot51
Copy link
Member

That's ok, I think it is fine as-is

@jackpot51
Copy link
Member

Since this is an improvement over how it was before, I will merge so it makes it into the next ISO. Further issues may be filed concerning the master branch

@jackpot51 jackpot51 merged commit f7584be into pop-os:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants