b33c5e2 (latest version) does not work on 20.04

[egibbm]

(1) Issue/Bug Description:

pop-shell is not loaded. No pop-shell icon on top right bar. Windows size/locations are not managed/tiled. Shortcuts to manage windows cannot be invoked.

(2) Steps to reproduce (if you know):

pop-shell upgrade.

(3) Expected behavior:

pop-shell works.

(4) Distribution (run cat /etc/os-release):

$ cat /etc/os-release
NAME="Pop!_OS"
VERSION="20.04 LTS"
ID=pop
ID_LIKE="ubuntu debian"
PRETTY_NAME="Pop!_OS 20.04 LTS"
VERSION_ID="20.04"
HOME_URL="https://pop.system76.com"
SUPPORT_URL="https://support.system76.com"
BUG_REPORT_URL="https://github.com/pop-os/pop/issues"
PRIVACY_POLICY_URL="https://system76.com/privacy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal
LOGO=distributor-logo-pop-os

(5) Gnome Shell version:

$  dpkg -l gnome-shell
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version                                              Architecture Description
+++-==============-====================================================-============-=====================================
ii  gnome-shell    3.36.7-0ubuntu0.20.04.1pop1~1614014876~20.04~4e7877a amd64        graphical shell for the GNOME desktop

(6) Pop Shell version (run apt policy pop-shell or provide the latest commit if building locally):

$ apt policy pop-shell
pop-shell:
  Installed: 1.1.0~1625501479~20.04~b33c5e2
  Candidate: 1.1.0~1625501479~20.04~b33c5e2
  Version table:
 *** 1.1.0~1625501479~20.04~b33c5e2 1001
       1001 http://ppa.launchpad.net/system76/pop/ubuntu focal/main amd64 Packages
       1001 http://ppa.launchpad.net/system76/pop/ubuntu focal/main i386 Packages
        100 /var/lib/dpkg/status

(7) Where was Pop Shell installed from:

pop-shop

(8) Monitor Setup (2 x 1080p, 4K, Primary(Horizontal), Secondary(Vertical), etc):

2 monitors: 1080 and 1440
Primary Horizontal, Secondary Horizontal

(9) Other Installed/Enabled Extensions:

$ ls -1 ~/.local/share/gnome-shell/extensions
clipboard-indicator@tudmotu.com
HijriCalendar@oxygenws.com
sound-output-device-chooser@kgshank.net

$ ls -1 /usr/share/gnome-shell/extensions/
alt-tab-raise-first-window@system76.com
always-show-workspaces@system76.com
ding@rastersoft.com
pop-shell@system76.com
pop-shop-details@system76.com
system76-power@system76.com
ubuntu-appindicators@ubuntu.com
ubuntu-dock@ubuntu.com

(10) Other Notes:

Going to https://extensions.gnome.org/local/, pop-shell is showing error

From log I can see the following detail:

$ journalctl /usr/bin/gnome-shell
Jul 06 12:23:38 thinkworker gnome-shell[5583]: JS ERROR: Extension pop-shell@system76.com: ImportError: No JS module 'windowPreview' found in search path
                                               @/usr/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:38:27
                                               _callExtensionInit@resource:///org/gnome/shell/ui/extensionSystem.js:425:13
                                               loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:346:27
                                               _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:599:18
                                               collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17
                                               _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:574:19
                                               _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:608:18
                                               _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:639:18
                                               init@resource:///org/gnome/shell/ui/extensionSystem.js:56:14
                                               _initializeUI@resource:///org/gnome/shell/ui/main.js:257:22
                                               start@resource:///org/gnome/shell/ui/main.js:146:5
                                               @<main>:1:47
Jul 06 12:23:38 thinkworker gnome-shell[5583]: JS ERROR: Could not load extension ubuntu-dock@ubuntu.com: Error: Missing metadata.json
                                               createExtensionObject@resource:///org/gnome/shell/ui/extensionSystem.js:281:19
                                               _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:594:34
                                               collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17
                                               _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:574:19
                                               _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:608:18
                                               _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:639:18
                                               init@resource:///org/gnome/shell/ui/extensionSystem.js:56:14

[abhisarshukla]

I updated pop os today and this same error happened, with the same JS ERROR message in journalctl.

As far as I can tell this error is caused because imports.ui.windowPreview is not present in GNOME shell 3.36.7 which pop os 20.04 uses.
The latest commit (b33c5e2) to pop shell imports ui.windowPreview and therefore it breaks the extension for previous versions of GNOME Shell.

[ilteoood]

Same error here

[boenshao]

Can confirm the same issue

[brunordgs]

I'm facing the same issue

[henriqueffc]

I'm having the same problem.

[brunobmello25]

same error here

[mattchooness]

I have the same issue.

[sdkmor]

Same error here.

[jacobgkau]

Confirmed Pop Shell is not working on a 20.04 installation. It looks like #1061 was merged without standard approvals and regression testing, I'll follow up to see what was going on with that.

[jacobgkau]

A fix (revert) has been pushed, 3873fc5. It's in the process of being released.

[mattchooness]

Just upgraded pop-shell to 3873fc5 and everything is back working again. Thanks for the quick fix.

[jmmaranan]

Thanks @jacobgkau, @jackpot51 and everyone. Sorry and my bad. I'll send in an updated fix and make sure it is tested thru the process.

[js-beaulieu]

Can confirm, just updated and it works again. Thanks for the quick fix indeed.

[c2p-cmd]

OMG! It works again! Thank you devs!

[henriqueffc]

Thanks. Congratulations to System76 engineers for Pop!_OS.

[egibbm]

Thank you. I can confirm the revert works after updated the package and restarted the system (probably a simple logout/login will do).
Closing the issue.