Fix handling skip taskbar on LTS and latest

[jmmaranan]

Fixes #1051 (when skip taskbar on/off)
Fixes #1055 (skip taskbar off)
Fixes #1058 (skip taskbar on/off)
Fixes #1066 - 20.04 LTS 3.36 (skip taskbar on/off)
#1023 is not on the switch.
Fixes #1034 - added Guake and ddterm to default floats

Need to test against ddterm or guake (skip taskbar but need to be floating by default - which I think need to be added to config.ts). These in addition to Sleek (minimize to tray only which is one of those types of windows that are being supported by this feature).

The skip taskbar feature is also on a switch. And by default on now in prefs.js

Hopefully this is better than the last PR.

[jacobgkau]

Confirmed #1055 is fixed. #1051 and #1058 only apply to GNOME 40. Confirmed #1066 and #1023 have not regressed.

Regression testing passed:
shell-pr1069-groovy.txt
shell-pr1069-focal.txt

On both Pop!_OS 21.04 and 20.04, #1022 is currently still an issue with the published version (b33c5e2 / 3873fc5) and this PR's version (5f8b84c). I'm approving since it's not a regression, but I've re-opened that issue.

[jmmaranan]

Hi @jacobgkau, was all of #1022 not working. I see multiple items there.

I defaulted the skip taskbar in prefs.js to turned off. Maybe that's what it was. Why #1022 is not working. But it should

[jacobgkau]

@jmmaranan Thank you for pointing out the preference. Since this was briefly defaulting to enabled, I didn't realize I needed to go into the extension settings and enable it manually now.

The setting is working. When it's enabled, Sleek and Conky both show up in Workspaces; when it's disabled, neither Sleek nor Conky show up in Workspaces. (Sleek is supposed to show up, but Conky is not.)

I'm wondering if the UX makes sense for this. First, the preference Show Skip Taskbar doesn't really suggest to me that it has anything to do with the Workspaces view, or tell me which applications it applies to (the launcher shortcut to toggle it, Toggle Minimized to Tray Windows, is easier to understand.) But also, I don't think we're expecting users to navigate to Extensions -> Pop Shell, and a user wouldn't know to search for the option in the Launcher without knowing what it's called.

Perhaps we could have a hard-coded (or configurable in .config) list of apps that the Skip Taskbar setting applies to? Similar to floating exceptions, but it doesn't necessarily need to have a GUI-- there isn't much preference here, an app like Sleek that has a titlebar and an X button should show up while an app like Conky that's more of an overlay or widget shouldn't show up. A list like that would require manual updating, but this would be simpler for the end user, and it would also allow e.g. having the setting on for Sleek and off for Conky, which isn't currently possible with the single on/off switch. Would that be practical to do?

[jmmaranan]

I added exceptions currently hard coded on config.ts for the time being. I left the prefs.js to default true for the feature but renamed the title/label so it syncs with the launcher name.

[jmmaranan]

Sorry @jacobgkau - I added Guake and ddterm to default floats because Conky and they are kind of interact with the skip task bar too. So pulled in #1034 as to be fixed by this PR :)