New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash overview on 4x when min tray enabled and remove dupe app icons on switch-app #1255
Conversation
@mmstick Hey, just a small heads-up that it's not merge ready. Code review comments |
@Bananaman - do you know where those code review comments are at? Don't see them here on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the code review. Sorry, it's been a while since I used GitHub and they've changed how code reviews work. It turns out that I had to go in and submit the whole batch of comments with an extra click. :)
Thanks for the review. I will get coding tomorrow when time permits |
And thank you very much for tackling these issues! Pop Shell is a fantastic extension, so it's great that we are close to stopping these crashes. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes #1094. There is no longer a second Android Studio entry in the Alt-Tab application switcher when an emulator is running. (21.10 & 20.04)
Sleek with Minimize to Tray enabled still shows up in the overview, is still tiled/gets an active hint, can still be moved/resized using the keyboard, and still shows up in the Alt-Tab application switcher. (21.10 & 20.04)
From what I understand, #1251 was already mitigated by #1249, but this new solution doesn't require doing as much version checking, is more correct, and will thus be easier to maintain.
Regression testing passed:
shell-pr1255-impish.txt
shell-pr1255-focal.txt
Hopefully fixes #1251 for gnome 4x users. This should enable 4x to see the overview for minimized to tray apps and corresponding windows. E.g. Sleek used as a minimized to tray app
Also fixes #1094 - remove the duplicate app icons introduced by adding skip task bar windows. This also makes skip-task-bar windows behave as if they are normal icons on the switcher (if have multiple associated windows, they get the same treatment as normal - shows an arrow icon when Sleek has multiple open instances)
On Gnome 4x:
On Gnome 3x: