Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash overview on 4x when min tray enabled and remove dupe app icons on switch-app #1255

Merged
merged 2 commits into from Nov 29, 2021
Merged

fix: crash overview on 4x when min tray enabled and remove dupe app icons on switch-app #1255

merged 2 commits into from Nov 29, 2021

Conversation

jmmaranan
Copy link
Contributor

@jmmaranan jmmaranan commented Nov 26, 2021

Hopefully fixes #1251 for gnome 4x users. This should enable 4x to see the overview for minimized to tray apps and corresponding windows. E.g. Sleek used as a minimized to tray app

Also fixes #1094 - remove the duplicate app icons introduced by adding skip task bar windows. This also makes skip-task-bar windows behave as if they are normal icons on the switcher (if have multiple associated windows, they get the same treatment as normal - shows an arrow icon when Sleek has multiple open instances)

On Gnome 4x:
image

On Gnome 3x:
image

mmstick
mmstick previously approved these changes Nov 26, 2021
@Arcitec
Copy link

Arcitec commented Nov 27, 2021

@mmstick Hey, just a small heads-up that it's not merge ready. Code review comments above below (😆) mention at least 1 bug introduced by these changes. Possibly 2 bugs. And the window type check needs a small adjustment to actually exclude OR windows. Other than that it looks very good. Just some small adjustments necessary.

@jmmaranan
Copy link
Contributor Author

@Bananaman - do you know where those code review comments are at? Don't see them here on this PR.

Copy link

@Arcitec Arcitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the code review. Sorry, it's been a while since I used GitHub and they've changed how code reviews work. It turns out that I had to go in and submit the whole batch of comments with an extra click. :)

src/extension.ts Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
@jmmaranan
Copy link
Contributor Author

Thanks for the review. I will get coding tomorrow when time permits

@Arcitec
Copy link

Arcitec commented Nov 27, 2021

Thanks for the review. I will get coding tomorrow when time permits

And thank you very much for tackling these issues! Pop Shell is a fantastic extension, so it's great that we are close to stopping these crashes. :)

@jmmaranan jmmaranan changed the title fix: crash overview on 4x when min tray enabled fix: crash overview on 4x when min tray enabled and remove dupe app icons on switch-app Nov 28, 2021
src/extension.ts Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #1094. There is no longer a second Android Studio entry in the Alt-Tab application switcher when an emulator is running. (21.10 & 20.04)

Sleek with Minimize to Tray enabled still shows up in the overview, is still tiled/gets an active hint, can still be moved/resized using the keyboard, and still shows up in the Alt-Tab application switcher. (21.10 & 20.04)

From what I understand, #1251 was already mitigated by #1249, but this new solution doesn't require doing as much version checking, is more correct, and will thus be easier to maintain.

Regression testing passed:
shell-pr1255-impish.txt
shell-pr1255-focal.txt

@mmstick mmstick merged commit ad86626 into pop-os:master Nov 29, 2021
@jmmaranan jmmaranan deleted the fix-1251-4x-overview branch December 11, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants