Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update order of steps for local-install #782

Merged
merged 1 commit into from
Dec 23, 2020
Merged

fix: update order of steps for local-install #782

merged 1 commit into from
Dec 23, 2020

Conversation

jmmaranan
Copy link
Contributor

@jmmaranan jmmaranan commented Dec 20, 2020

Fixes #760 #703

New install of ext using source if none exists.
Existing should still work.

Wayland - need to still logout/login.

Note: sleep 3 was added because the gnome-extensions enable command was being executed prior to Meta.eval resolves to restart the shell. If there is another elegant way, I am happy to update the PR.

Fixes new install of ext if none exists.
Existing should still work.

Wayland - need to still logout/login
@jacobgkau jacobgkau requested a review from a team December 21, 2020 18:04
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets the local-install script working on Ubuntu 20.10 without needing to manually restart the shell, still works as expected on Ubuntu 20.04.

@jacobgkau jacobgkau requested a review from a team December 21, 2020 18:04
@jacobgkau jacobgkau merged commit 425f1e4 into pop-os:master Dec 23, 2020
@jmmaranan jmmaranan deleted the fix-local-install branch December 23, 2020 01:02
@BlackHawk185
Copy link

BlackHawk185 commented Feb 18, 2022

#760 Still exists, most likely Distro specific

@fivitti fivitti mentioned this pull request Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to Install
4 participants