New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move settings to xprofile and don't overwrite existing settings. #182
Conversation
Tested the following scenarios on Pop 20.10 and Ubuntu 20.04:
(For the record, I also double-checked that |
Confirmed the xprofile script still works as intended with one or multiple displays, and all of the test cases from my previous comment still work, with the latest changes on |
Fixes #179.
While placing this command in
/etc/profile.d
did not impact the ability to use multiple displays, it did cause the display configuration to be lost if/etc/profile
is re-run after login, and caused error messages when logging in remotely. This PR makes the following changes:/etc/profile.d
./etc/xprofile
, which is only run at graphical login by GDM and other display managers./etc/xprofile.d
does not exist by default, nor does/etc/xprofile
. Using/etc/xprofile.d
would still require creating/etc/xprofile
first, so it's simpler not to use it.CurrentMetaMode
and will appendForceFullCompositionPipeline
onto the existingCurrentMetaMode
so as not to overwrite existing display settings. Only ifCurrentMetaMode
doesn't exist is the defaultnvidia-auto-select
option used.I'm testing thoroughly and will un-mark as draft when this is ready for full review.