Revert "daemon: Always enable GPU power" #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the device ID at PCI enumeration so it does not need to be fetched from sysfs again later. Search /usr/share/doc for the NVIDIA driver folder instead of getting the version of the loaded driver. Allows getting the dGPU features when the driver is unloaded and the PCI device has been removed from the bus. Signed-off-by: Tim Crawford <tcrawford@system76.com>
This reverts commit 1e1599a. oryp4 does not behave correctly when the GPU is left on the bus in integrated mode. Signed-off-by: Tim Crawford <tcrawford@system76.com>
jackpot51
approved these changes
May 2, 2022
n3m0-22
approved these changes
May 2, 2022
There was a problem hiding this comment.
Fan issue is still fixed with this same as with #326, but there is no more error on a non-switchable system. The GPU fan still kicks in for a couple seconds every 3 minutes or so while working. That is in Integrated mode. The fans run normally in the NVIDIA modes. In Integrated mode the output of system76-power graphics power is off (discrete). These are the same results I had with the workaround.
With this PR:
Without:
All of the following tests passed
CLI
Tasks which test the behavior of the CLI client.
- Power profiles can be queried and set
- Laptop with switchable graphics:
- Switchable graphics can be queried
- Command returns
not switchableon a non-switchable system - Command returns
switchableon a laptop with switchable graphics
- Command returns
- Switching from Integrated to NVIDIA
- Switching from Integrated to Hybrid
- Switching from Integrated to Compute
- Switching from NVIDIA to Integrated
- Switching from NVIDIA to Hybrid
- Switching from NVIDIA to Compute
- Switching from Hybrid to Integrated
- Switching from Hybrid to NVIDIA
- Switching from Hybrid to Compute
- Switching from Compute to Integrated
- Switching from Compute to NVIDIA
- Switching from Compute to Hybrid
- Discrete graphics power state can be queried and set
- Switchable graphics can be queried
GNOME Shell
Tasks which test the behavior of the shell extension.
- Test that the power profile can be switched, and that the dots are correct
- Test that any power profile change from the CLI is reflected in the extension
- When switching to balanced, with screen brightness maxed, screen brightness drops to 50%
- When switching to battery, with screen brightness maxed, screen brightness drops to 10%
- When switching to balanced, with screen brightness minimized, screen brightness does not change
- When restarting the daemon, and the daemon defaults to a balanced profile, the brightness should not change
- When restarting the system, screen brightness should be the same as before
- Laptop with switchable graphics:
- Switching from Integrated to NVIDIA
- Switching from Integrated to Hybrid
- Switching from Integrated to Compute
- Switching from NVIDIA to Integrated
- Switching from NVIDIA to Hybrid
- Switching from NVIDIA to Compute
- Switching from Hybrid to Integrated
- Switching from Hybrid to NVIDIA
- Switching from Hybrid to Compute
- Switching from Compute to Integrated
- Switching from Compute to NVIDIA
- Switching from Compute to Hybrid
- Test that switchable graphics changes from the CLI are reflected in the extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oryp4 doesn't behave correctly with the GPU enabled in integrated mode because it doesn't support RTD3.
Revert the change that left the GPU always enabled, and cherry-pick the change to get supported features while in integrated mode.
Fixes: #325