Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler Improvements #13

Merged
merged 9 commits into from
Feb 25, 2022
Merged

Scheduler Improvements #13

merged 9 commits into from
Feb 25, 2022

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Feb 8, 2022

  • Fixes the config trying to load from /usr/lib/system76-scheduler/config.ron instead of the correct path of /usr/share/system76-scheduler/config.ron for configuring the background and foreground priorities.
  • Uses tracing for logging of messages. Running sudo env RUST_LOG system76-scheduler daemon will have an instance with debug logs printed.
  • Adds error messages for configuration files that failed to deserialize
  • Makes it possible to have process assignments without automatic background and foreground adjustments
  • Combines AutoBackgroundPriority events with the UpdateProcessMap event because both are generated at the same time.

Closes #9
Closes #12
Closes #14

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this branch causes system76-scheduler to be kept back when running apt upgrade. This also causes an uninstallable update in the Pop!_Shop:

Screenshot from 2022-02-24 12-56-36

Since irqbalance is installed by default (recommended by ubuntu-standard) on current installations, we can't just conflict with it out of the blue, since apt won't remove a package via a normal upgrade. May need an empty transitional package or some other solution (or the irqbalance removal could be a 22.04 feature.)

@mmstick
Copy link
Member Author

mmstick commented Feb 24, 2022

Sad. I'll remove the last commit then. Maybe it'd be best to make it a dummy package.

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes config file loading; I can now change the default nice levels for foreground & background tasks using the file in /usr/share (although that file is part of the package and seems to be overwritten on upgrade, which is expected.)

Foreground changes are no longer logged to journalctl, as stated.

After setting foreground and background to None, manual assignments still take effect.

When running a command in a terminal (e.g. stress -c 1), it sometimes takes a few focus switches to get the command itself (instead of just the terminal GUI) to have a "focused" nice level, testing with Konsole (while watching top in GNOME Terminal). However, that is not a regression.

@mmstick mmstick merged commit bb022b5 into master Feb 25, 2022
@mmstick mmstick deleted the scheduler branch February 25, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants