New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Rollup #92
Conversation
Fixes an early return of the service SchedPaths::new returns an error. Closes #91
This built fine locally, but has not built successfully on the build server. The logs have been cycled out, so I can't see what the problem was. |
Maybe it'll build on the server this time |
Successfully built this time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression testing passed:
- Focus-based assignments are working with the default config (both .debs and Flatpaks).
- Focus-based assignments work with custom values in
/etc
. -
nice -n #
works with the default config. - A custom profile with no niceness defined still has foreground/background applied.
- Only foreground niceness is applied in this situation. (Not a regression.)
- A custom profile with a niceness defined inline (under
process-scheduler/
) works. - A custom profile with a niceness defined separately (in
config.kdl
) works. - Config reloading works with
system76-scheduler daemon reload
,systemctl reload com.system76.Scheduler.service
, andsystemctl restart com.system76.Scheduler.service
. - PipeWire integration works; when an app starts playing audio, it's assigned the niceness of the
pipewire
group and retains it until it's closed. It gets regular foreground/background niceness again when it's relaunched (or sooner if the audio stream stops.) - After disabling the foreground/background profiles, other profiles still work.
I noticed restarting the daemon (via systemctl restart com.system76.Scheduler.service
) is a lot faster now.
Fixes
/proc/self/exe
Improvements
Chores
Closes #91