Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize with cognito hosted UI #6

Merged
merged 14 commits into from
Feb 13, 2024
Merged

Authorize with cognito hosted UI #6

merged 14 commits into from
Feb 13, 2024

Conversation

mrtj
Copy link
Contributor

@mrtj mrtj commented Dec 20, 2023

This PR introduces the feature of authorizing the streamlit app with AWS Cognito hosted UI. The PR also includes a specific example in the examples folder.

@mrtj mrtj mentioned this pull request Dec 20, 2023
@shreyasdamle
Copy link

Hi team, can you merge this PR and release the changes? I would love to try out this feature.

@lambda-science
Copy link
Contributor

lambda-science commented Feb 13, 2024

Same :) @pop-srw ? 👀

@pop-srw pop-srw merged commit a8cced4 into pop-srw:main Feb 13, 2024
@pop-srw
Copy link
Owner

pop-srw commented Feb 13, 2024

I apologize for the delayed response. I want to express my gratitude to everyone who has shown interest in my project. I'd like to give special thanks to @mrtj for your contribution, your work is truly amazing. Thank you so much.

@lambda-science
Copy link
Contributor

Would be nice to maybe update to pydantic >2 @mrtj 👀Unfortunatly I have dep conflict with Pydantic <1 ahah

@mrtj
Copy link
Contributor Author

mrtj commented Feb 14, 2024

@lambda-science great idea! Could you open a separate issue to track this request?

@lambda-science
Copy link
Contributor

@lambda-science great idea! Could you open a separate issue to track this request?

I forked and will try to see if it works out of the box with pydantic 2
If yes, I will do a PR

@lambda-science
Copy link
Contributor

@lambda-science great idea! Could you open a separate issue to track this request?

Btw after this update, in my streamlit mult-page app I have a lot of empty space after logging in.
Have you already experienced that ? How to solve it @mrtj
image

@lambda-science
Copy link
Contributor

lambda-science commented Feb 14, 2024

@lambda-science great idea! Could you open a separate issue to track this request?

Btw after this update, in my streamlit mult-page app I have a lot of empty space after logging in. Have you already experienced that ? How to solve it @mrtj image

Heh this is solved by using use_cookies=False not sure what's the impact of not using cookie !

@lambda-science
Copy link
Contributor

lambda-science commented Feb 14, 2024

Sorry for the spam maybe I really should open a private chat or another issue but with latest streamlit, the new hosted UI show this warning:
image
And I can't use hosted UI. When I log in, the page refresh and I'm not logged in (wether with ou without use of cookies).
Maybe I didn't configure my Cognito properly. @mrtj

EDIT: I think I know why. It's issues with experimental streamlit feature deleted in 1.30 !

@lambda-science
Copy link
Contributor

Please @mrtj do you know why when use_cookies=True there is so much empty space face invisible login form ? It's really annoying to use use_cookies=False my user need to login at each refresh :((
I spent so much time understanding where this bug comes from but I can't :/ @pop-srw

@lambda-science
Copy link
Contributor

Related issue: Mohamed-512/Extra-Streamlit-Components#62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants