Show runtime error list docked to the bottom of the preview #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a runtime error occurs, we don’t want to completely cover the preview like we do for a compilation error. Instead, slide up a list of errors docked to the bottom of the preview column.
Absolutely position the toolbar and make space for it using padding. Means that the whole thing now takes up 100% of the viewport height, instead of more than 100%. Also means that opening the toolbar covers the environment rather than pushing it down, which I think is better. Ultimately I think flexbox is probably the right move here but this is an improvement from the previous layout.
outoftime
added a commit
that referenced
this pull request
Feb 6, 2016
Show runtime error list docked to the bottom of the preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a runtime error occurs, we don’t want to completely cover the preview like we do for a compilation error. Instead, slide up a list of errors docked to the bottom of the preview column.
Also changes the toolbar/menu to be absolutely positioned, which is better for the layout.