Fix DBus issues with the launcher script and fix LD_LIBRARY_PATH. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses an adapted version of fcarlier fix.
includes the current directory due the calculated variable ends with ":". Avoid that not adding LD_LIBRARY_PATH if not set. Issue discovered by popcornmix who sent me this link: http://stick.gk2.sk/2009/10/wrong-usage-of-ld_library_path/
popcornmix
added a commit
that referenced
this pull request
Nov 25, 2013
Fix DBus issues with the launcher script and fix LD_LIBRARY_PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7f93b61 Fixes DBus issues #59 and #97.
It's an adaptation of the fix proposed by fcarlier in #59.
0e965c1 Fixes an issue with LD_LIBRARY_PATH discovered by @popcornmix.
If you have a bad lib in the current directory it will be included if your LD_LIBRARY_PATH is empty.
This is because LD_LIBRARY_PATH currently resolves to "/opt/vc/lib:/usr/lib/omxplayer:" causing to include the current directory because it ends in ":". This fix avoids to include non-existing LD_LIBRARY_PATH env var.
This fixes are already working on the launcher script I use for my packages.