Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ffmpeg] squash: Proper fix for corruption with luma prediction on QPUs
- Loading branch information
1 parent
054197f
commit b70b40a
b70b40aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I still see the horizontal streaking with this patch (only with Sintel 720p, not Sintel 1080p), in case this is meant to address that issue. Sintel 1080p now plays more-or-less OK (no more blue/purple pixelation), but remains juddery.
b70b40aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, horizontal streaking is a different issue to the luma predication bug.
Suspect a caching issue. We're investing.
I've pushed another commit which supports skipping decode of non-reference frames.
While it doesn't fix the issue when failing to keep up, it should reduce the symptoms (e.g. less likely to get out of sync audio).
b70b40aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that actually works rather well with Sintel 1080p!
b70b40aThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ffmpeg supports skipping non-reference frames for MPEG-2, MPEG-4, H.264 which gives a graceful way of coping when running behind.
Only recently spotted that H.265 doesn't support this so it tends to suffer from out-of-sync audio and codec getting reset when running behind. Latest commit helps that.