Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions workflow that pushes a new Docker image to Github Docker Registry #221

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

martin-g
Copy link
Contributor

The current version of the Github Action workflow would push a new Docker image on every push to the master branch.
The images will be pull-able from https://github.com/popgenmethods/smcpp/pkgs/container/smcpp

AMD64 and ARM64 Docker images from my testing could be seen at https://github.com/martin-g/smcpp/pkgs/container/smcpp

If you prefer to push to https://hub.docker.com see https://github.com/docker/login-action#docker-hub, but for this you will need to setup Github secrets with the credentials.

@martin-g
Copy link
Contributor Author

Any feedback on the proposed changes ?

…Docker Registry

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@terhorst
Copy link
Collaborator

Hi Martin,

Apologies for the delay, and thanks for all you hard work on this! Everything looks good. As luck would have it, work is buying me a new ARM-based Mac, so I will soon have the ability to test out the new images. As soon as I get that done I will merge your PR. Thanks again!

@martin-g
Copy link
Contributor Author

Awesome!
Thank you, @terhorst !

@terhorst terhorst merged commit 723c14d into popgenmethods:master Oct 25, 2022
@martin-g
Copy link
Contributor Author

Thanks for merging it, @terhorst !

It seems you will have to change the visibility of the new Docker image to public manually.
https://github.com/orgs/popgenmethods/packages is empty for me!
But https://github.com/popgenmethods/smcpp/actions/runs/3323388223/jobs/5493663203 is successful!

$ docker pull ghcr.io/popgenmethods/smcpp:221025-1834
Error response from daemon: Head "https://ghcr.io/v2/popgenmethods/smcpp/manifests/221025-1834": denied: denied

It seems the Docker image is there but private.

Please go to https://github.com/orgs/popgenmethods/packages/container/smcpp/settings, scroll to the bottom (the Danger Zone) and change the visibility to Public.
This is a one time operation for each new Docker image.
Thanks in advance!

@martin-g martin-g deleted the multi-platform-docker-image branch October 26, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants