Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various measure problems wrt GROUPING #24

Closed
kclaes opened this issue Apr 16, 2012 · 9 comments
Closed

Various measure problems wrt GROUPING #24

kclaes opened this issue Apr 16, 2012 · 9 comments

Comments

@kclaes
Copy link

kclaes commented Apr 16, 2012

Hi guys,

I've found quite a few errors in the measurement definitions. It's all related to grouping references not matching the coding block identifiers. This causes only the last code block to be included in the measure.

I'm sure you'll want to add them as a .patch file, but since I don't know how those work, I'll add them seperately as a diff file. One diff per comment.

The affected measures are 0036, 0038, 0056, 0059, 0061, 0062, 0084.
@kclaes
Copy link
Author

kclaes commented Apr 16, 2012 

 measure_props/NQF_Retooled_Measure_0036.xlsx.json |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/measure_props/NQF_Retooled_Measure_0036.xlsx.json b/measure_props/NQF_Retooled_Measure_0036.xlsx.json
index 36a33f7..602d05e 100644
--- a/measure_props/NQF_Retooled_Measure_0036.xlsx.json
+++ b/measure_props/NQF_Retooled_Measure_0036.xlsx.json
@@ -8,7 +8,7 @@
     "standard_concept_id": "N_c452",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "N_c231, N_c232, N_c553",
+    "standard_code_list": "c231, c232, c553",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_1895": {
@@ -128,7 +128,7 @@
     "standard_concept_id": "N_c453",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "N_c176, N_c221, N_c223",
+    "standard_code_list": "c176, c221, c223",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_799": {
@@ -200,7 +200,7 @@
     "standard_concept_id": "N_c454",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "N_c225, N_c226, N_c556",
+    "standard_code_list": "c225, c226, c556",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_1896": {
@@ -248,7 +248,7 @@
     "standard_concept_id": "N_c455",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "N_c229, N_c230, N_c559",
+    "standard_code_list": "c229, c230, c559",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_1897": {
@@ -296,7 +296,7 @@
     "standard_concept_id": "N_c456",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "N_c227, N_c228, N_c560",
+    "standard_code_list": "c227, c228, c560",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_1898": {
@@ -392,7 +392,7 @@
     "standard_concept_id": "N_c552",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "N_c159, N_c27",
+    "standard_code_list": "c159, c27",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_2128": {

@kclaes
Copy link
Author

kclaes commented Apr 16, 2012 

 measure_props/NQF_Retooled_Measure_0038.xlsx.json |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/measure_props/NQF_Retooled_Measure_0038.xlsx.json b/measure_props/NQF_Retooled_Measure_0038.xlsx.json
index 009debd..f0c2a17 100644
--- a/measure_props/NQF_Retooled_Measure_0038.xlsx.json
+++ b/measure_props/NQF_Retooled_Measure_0038.xlsx.json
@@ -1028,7 +1028,7 @@
     "standard_concept_id": "N_c1079",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "N_c1056, N_c1057",
+    "standard_code_list": "c1056, c1057",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_3171": {

@kclaes
Copy link
Author

kclaes commented Apr 16, 2012 

 measure_props/NQF_Retooled_Measure_0056.xlsx.json |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/measure_props/NQF_Retooled_Measure_0056.xlsx.json b/measure_props/NQF_Retooled_Measure_0056.xlsx.json
index 1453e11..e9d822e 100644
--- a/measure_props/NQF_Retooled_Measure_0056.xlsx.json
+++ b/measure_props/NQF_Retooled_Measure_0056.xlsx.json
@@ -488,7 +488,7 @@
     "standard_concept_id": "N_c540",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "07/2009",
-    "standard_code_list": "N_c305, N_c438, N_c50, N_c51, N_c52, N_c53, N_c54, N_c55, N_c56",
+    "standard_code_list": "c305, c438, c50, c51, c52, c53, c54, c55, c56",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_727": {

@kclaes
Copy link
Author

kclaes commented Apr 16, 2012 

 measure_props/NQF_Retooled_Measure_0059.xlsx.json |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/measure_props/NQF_Retooled_Measure_0059.xlsx.json b/measure_props/NQF_Retooled_Measure_0059.xlsx.json
index a315dfb..c23a069 100644
--- a/measure_props/NQF_Retooled_Measure_0059.xlsx.json
+++ b/measure_props/NQF_Retooled_Measure_0059.xlsx.json
@@ -524,7 +524,7 @@
     "standard_concept_id": "N_c540",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "07/2009",
-    "standard_code_list": "N_c305, N_c438, N_c50, N_c51, N_c52, N_c53, N_c54, N_c55, N_c56",
+    "standard_code_list": "c305, c438, c50, c51, c52, c53, c54, c55, c56",
     "QDS_datatype_specific_attributes": ""
   },
   "N_121": {

@kclaes
Copy link
Author

kclaes commented Apr 16, 2012 

 measure_props/NQF_Retooled_Measure_0061.xlsx.json |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/measure_props/NQF_Retooled_Measure_0061.xlsx.json b/measure_props/NQF_Retooled_Measure_0061.xlsx.json
index 63d9712..62a018e 100644
--- a/measure_props/NQF_Retooled_Measure_0061.xlsx.json
+++ b/measure_props/NQF_Retooled_Measure_0061.xlsx.json
@@ -476,7 +476,7 @@
     "standard_concept_id": "N_c540",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "07/2009",
-    "standard_code_list": "N_c305, N_c438, N_c50, N_c51, N_c52, N_c53, N_c54, N_c55, N_c56",
+    "standard_code_list": "c305, c438, c50, c51, c52, c53, c54, c55, c56",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_2154": {

@kclaes
Copy link
Author

kclaes commented Apr 16, 2012 

 measure_props/NQF_Retooled_Measure_0062.xlsx.json |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/measure_props/NQF_Retooled_Measure_0062.xlsx.json b/measure_props/NQF_Retooled_Measure_0062.xlsx.json
index 8dbbd1f..f162de0 100644
--- a/measure_props/NQF_Retooled_Measure_0062.xlsx.json
+++ b/measure_props/NQF_Retooled_Measure_0062.xlsx.json
@@ -68,7 +68,7 @@
     "standard_concept_id": "N_c541",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "N_c202, N_c203, N_c504",
+    "standard_code_list": "c202, c203, c504",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_536": {
@@ -632,7 +632,7 @@
     "standard_concept_id": "N_c540",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "07/2009",
-    "standard_code_list": "N_c305, N_c438, N_c50, N_c51, N_c52, N_c53, N_c54, N_c55, N_c56",
+    "standard_code_list": "c305, c438, c50, c51, c52, c53, c54, c55, c56",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "N_542": {

@kclaes
Copy link
Author

kclaes commented Apr 16, 2012 

 measure_props/NQF_Retooled_Measure_0084.xlsx.json |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/measure_props/NQF_Retooled_Measure_0084.xlsx.json b/measure_props/NQF_Retooled_Measure_0084.xlsx.json
index c22fdfa..6b0a4fe 100644
--- a/measure_props/NQF_Retooled_Measure_0084.xlsx.json
+++ b/measure_props/NQF_Retooled_Measure_0084.xlsx.json
@@ -176,7 +176,7 @@
     "standard_concept_id": "A_c382",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "A_c472, A_c221, A_c228",
+    "standard_code_list": "472, A_c221, A_c228",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "A_1308": {
@@ -188,7 +188,7 @@
     "standard_concept_id": "A_c382",
     "standard_taxonomy": "GROUPING",
     "standard_taxonomy_version": "",
-    "standard_code_list": "A_c472, A_c221, A_c228",
+    "standard_code_list": "472, A_c221, A_c228",
     "QDS_datatype_specific_attributes": "datetime"
   },
   "A_7031": {

@ssayer
Copy link
Contributor

ssayer commented Apr 17, 2012

bug confirmed, fix is in progress

@ssayer
Copy link
Contributor

ssayer commented Apr 27, 2012

Resolved and pushed to measures develop branch

@ssayer ssayer closed this as completed Apr 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssayer @kclaes