Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed readers to members #9

Merged
merged 4 commits into from
Jan 27, 2017
Merged

renamed readers to members #9

merged 4 commits into from
Jan 27, 2017

Conversation

danikp
Copy link

@danikp danikp commented Jan 25, 2017

CouchDB documentation states that _security object contains admins and members, not readers. although readers seems to be accepted and working same as members, they are not shown at Fauxton and it may lead to confusion and may lead to other issues in the future.

This PR updates all mentions of 'reader' to 'member' to match CouchDB terminology and docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.528% when pulling 20aa81f on danikp:readers_to_members into 25cb4de on popojargo:master.

@coveralls
Copy link

coveralls commented Jan 25, 2017

Coverage Status

Coverage increased (+0.5%) to 41.011% when pulling ef2a64e on danikp:readers_to_members into 25cb4de on popojargo:master.

@popojargo
Copy link
Owner

@danikp Can you make your pull request on the original repository (dready92/phpOnCouch)

Eventually, the whole library will be moved to the PHPOnCouch Organization but I didn't have the time yet.
When we will be moved, a clear message will be indicated on packagist and git.

@coveralls
Copy link

coveralls commented Jan 25, 2017

Coverage Status

Coverage increased (+0.5%) to 41.011% when pulling d3579f8 on danikp:readers_to_members into 25cb4de on popojargo:master.

@popojargo popojargo changed the base branch from master to develop January 27, 2017 03:11
@popojargo popojargo changed the base branch from develop to master January 27, 2017 03:12
@popojargo popojargo merged commit 23ecf16 into popojargo:master Jan 27, 2017
@danikp danikp deleted the readers_to_members branch March 23, 2017 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants