refactor(spm-package) resolve pkg dep from current to root #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (version || !pkg.father) { | ||
| break; | ||
| } | ||
| pkg = pkg.father; |
There was a problem hiding this comment.
这块逻辑还是跟原来一样吧，现在扁平化的目录父级模块并不是上一层目录，所以只要两层判断就好了。
There was a problem hiding this comment.
从上往下找还有个潜在的问题。问了邵帅，在他的使用中也是有些场景的。
以下依赖链：
a -> b -> c@0.1.0
-> c@0.1.0
然后在 a 中 link b，在 b 中 link c 。如果从上往下找，那么 b 的依赖 c 会取 a 下面的 c ，则会出现 c 的修改在调试 b 时有效，而调试 a 时无效的问题。
There was a problem hiding this comment.
逻辑这样？
从下往上找两层，然后如果不是 rootPkg 的话，再找一遍 rootPkg 的 spm_modules。
sorrycc
force-pushed
the
fix-deps-resolve
branch
from
0122b60
to
c13c308
Compare
|
逻辑更新了。
|
|
+1 |
popomore
added a commit
that referenced
this pull request
Dec 22, 2014
refactor(spm-package) resolve pkg dep from current to root
|
0.10.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close spmjs/spm#1100
依赖查找改成由下往上查找，感觉这样更合乎逻辑，多出来的性能消耗理论上应该是比较少的。