Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the contents of the <svg> tag using {@html} in the component mode #40

Merged

Conversation

aradalvand
Copy link
Contributor

@aradalvand aradalvand commented Jul 23, 2023

Closes #39

I also replaced SvelteComponentTyped with SvelteComponent in svg.d.ts since SvelteComponentTyped is deprecated in Svelte 4 — see this.

@aradalvand
Copy link
Contributor Author

aradalvand commented Jul 23, 2023

One unrelated thing by the way: The TypeScript section in the README currently states that you should copy-and-paste those TypeScript declarations into a svg.d.ts file in your project; but since sveltekit-svg already comes with the svg.d.ts file included, can't users instead simply import it in their app.d.ts or whatever? Like so:

import '@poppanator/sveltekit-svg/dist/svg';

This seems to work just as well. So, should I update the README to reflect this?

@poppa
Copy link
Owner

poppa commented Jul 25, 2023

One unrelated thing by the way: The TypeScript section in the README currently states that you should copy-and-paste those TypeScript declarations into a svg.d.ts file in your project; but since sveltekit-svg already comes with the svg.d.ts file included, can't users instead simply import it in their app.d.ts or whatever? Like so:

import '@poppanator/sveltekit-svg/dist/svg';

This seems to work just as well. So, should I update the README to reflect this?

That's a good point. Feel free to update the README :)

@aradalvand
Copy link
Contributor Author

@poppa Done :)

@poppa poppa changed the base branch from main to feature/pr-40-renderHtml-42-tranformComponenHook July 27, 2023 07:58
@poppa poppa merged commit aa6a593 into poppa:feature/pr-40-renderHtml-42-tranformComponenHook Jul 27, 2023
@aradalvand
Copy link
Contributor Author

aradalvand commented Jul 27, 2023

@poppa Thanks! When will this be released if I may ask?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render the contents of the <svg> tag using {@html} in the component mode
2 participants