Oo a nea ext puls demo

[LeonardoIasi]

Additional HomSap demography of an simple OoA with Nenadertal introgression following Iasi et al. 2021 including the extended admixture pulse with a duration of 800 generations.

[codecov]

Codecov Report

Merging #1066 (61fd15d) into main (9454010) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1066   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          91       91           
  Lines        2917     2967   +50     
  Branches      348      351    +3     
=======================================
+ Hits         2903     2953   +50     
  Misses          6        6           
  Partials        8        8           

Impacted Files	Coverage Δ
stdpopsim/catalog/HomSap/demographic_models.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9454010...61fd15d. Read the comment docs.

[grahamgower]

Hi @LeonardoIasi! Thanks for the model addition! I haven't gone through the details, but it looks like there are a few code paths that aren't used in your nested extended_pulse() function. Given that you're calling the function only once with fixed values, maybe you could just assert that the conditions for these code paths dont happen and then remove that code?

[LeonardoIasi]

Hello,
yes the function has some if statements. But true since the parameters will not vary the function does not need to check them. I'll change the code and commit again. Thanks

[grahamgower]

LGTM.

[grahamgower]

@LeonardoIasi, would you please open an issue to track the QC of the model implementation as per the dev docs? https://stdpopsim.readthedocs.io/en/latest/development.html#demographic-model-review-process