Adding Huber et al 2017 DFE for HomSap #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkern
reviewed
Nov 9, 2021
stdpopsim/catalog/HomSap/dfes.py
Outdated
| description=description, | ||
| long_description=long_description, | ||
| mutation_types=[neutral, negative], | ||
| proportions=[0.3, 0.7], # [0.3 and 0.7 were used in Xin's analysis, but I couldn't find these values in the Huber paper] |
There was a problem hiding this comment.
i'm guessing this line is too long for the pre-commit syntax checkers
There was a problem hiding this comment.
ok, I wrapped that line and passed the pre-commit checks locally
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 92 92
Lines 2960 2972 +12
Branches 348 348
=======================================
+ Hits 2946 2958 +12
Misses 6 6
Partials 8 8
Continue to review full report at Codecov.
|
andrewkern
approved these changes
Nov 10, 2021
|
PR closes #1096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a DFE for HomSap, from Huber et al., 2017.
Related to #1096