-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Huber et al 2017 DFE for HomSap #1099
Conversation
stdpopsim/catalog/HomSap/dfes.py
Outdated
description=description, | ||
long_description=long_description, | ||
mutation_types=[neutral, negative], | ||
proportions=[0.3, 0.7], # [0.3 and 0.7 were used in Xin's analysis, but I couldn't find these values in the Huber paper] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm guessing this line is too long for the pre-commit syntax checkers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I wrapped that line and passed the pre-commit checks locally
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 92 92
Lines 2960 2972 +12
Branches 348 348
=======================================
+ Hits 2946 2958 +12
Misses 6 6
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me @chriscrsmith.
PR closes #1096 |
Adding a DFE for HomSap, from Huber et al., 2017.
Related to #1096