added stickleback genome...

[vitorpavinato]

referenced to added stickleback genome #1090

[codecov]

Codecov Report

Merging #1105 (bbdeed0) into main (be4b9b7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bbdeed0 differs from pull request most recent head c342934. Consider uploading reports for the commit c342934 to get more accurate results

@@            Coverage Diff             @@
##             main    #1105      +/-   ##
==========================================
- Coverage   99.53%   99.52%   -0.01%     
==========================================
  Files          92       95       +3     
  Lines        3015     2978      -37     
  Branches      360      350      -10     
==========================================
- Hits         3001     2964      -37     
  Misses          6        6              
  Partials        8        8              

Impacted Files	Coverage Δ
stdpopsim/catalog/GasAcu/__init__.py	100.00% <100.00%> (ø)
stdpopsim/catalog/GasAcu/genome_data.py	100.00% <100.00%> (ø)
stdpopsim/catalog/GasAcu/species.py	100.00% <100.00%> (ø)
stdpopsim/cli.py	98.16% <0.00%> (-0.23%)	⬇️
stdpopsim/citations.py	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4b9b7...c342934. Read the comment docs.

[vitorpavinato]

I initiated by running python3 -m maintenance add-species-ncbi 9307941 (see #819) to create the species.py and genome_data.py. I manually removed the quotation around each chromosome size value.

[vitorpavinato]

QC for stickleback #1091

[petrelharp]

Wouldn't this be

Suggested change

	name="Gasterosteus aculeatus",
	common_name="Gasterosteus aculeatus aculeatus (three-spined stickleback)",
	name="Gasterosteus aculeatus",
	common_name="Three-spined stickleback",

... ? Or, do we need the subspecies in name?

[vitorpavinato]

You are right! I should have edited it before. Thanks for catching it @petrelharp.

[petrelharp]

Ok, great! So, now you could either (a) make the change yourself in a new commit, or (b) just click the "commit suggestion" button on my suggestion. Then squash & rebase this PR (and ask if you need help with that?).

[petrelharp]

LGTM! Just a minor question about the "common name".

[petrelharp]

Whoops - forgot to fix up the tests...

[petrelharp]

Awesome! Just needs a squash & rebase.

[petrelharp]

The failing test is just a transient URL error; I'll merge this. Yay!!! Thanks!!!