-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PanTro #1215
Add PanTro #1215
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1215 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 98 99 +1
Lines 3182 3232 +50
Branches 414 415 +1
=======================================
+ Hits 3168 3218 +50
Misses 6 6
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @xin-huang. This looks great! The failing tests are just about code style, which can be fixed by using the pre-commit tool as described in the developer docs: https://popsim-consortium.github.io/stdpopsim-docs/latest/development.html#github-workflow
After that, I think this will be good to merge. It would be good to open an issue for the demographic model QC, separate to the species QC issue.
Hi @grahamgower |
Thanks @xin-huang. Could you please open a new issue to track the QC for the BonoboGhost_4K19 demographic model? |
In this pr, I added a demographic model for Pan troglodytes based on Kuhlwilm et al. 2019 Supplementary Table S2.2 column I and Table S3
Other parameters can be found in #1000