Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PanTro #1215

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Add PanTro #1215

merged 1 commit into from
Apr 25, 2022

Conversation

xin-huang
Copy link
Member

In this pr, I added a demographic model for Pan troglodytes based on Kuhlwilm et al. 2019 Supplementary Table S2.2 column I and Table S3

Other parameters can be found in #1000

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1215 (0085a31) into main (e8e055e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0085a31 differs from pull request most recent head 53b3812. Consider uploading reports for the commit 53b3812 to get more accurate results

@@           Coverage Diff           @@
##             main    #1215   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          98       99    +1     
  Lines        3182     3232   +50     
  Branches      414      415    +1     
=======================================
+ Hits         3168     3218   +50     
  Misses          6        6           
  Partials        8        8           
Impacted Files Coverage Δ
stdpopsim/catalog/PanTro/__init__.py 100.00% <100.00%> (ø)
stdpopsim/catalog/PanTro/demographic_models.py 100.00% <100.00%> (ø)
stdpopsim/catalog/PanTro/genome_data.py 100.00% <100.00%> (ø)
stdpopsim/catalog/PanTro/species.py 100.00% <100.00%> (ø)
stdpopsim/catalog/BosTau/demographic_models.py 100.00% <0.00%> (ø)
stdpopsim/catalog/HelAnn/genome_data.py
stdpopsim/catalog/HelAnn/species.py
stdpopsim/catalog/HelAnn/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e055e...53b3812. Read the comment docs.

@xin-huang xin-huang mentioned this pull request Apr 19, 2022
14 tasks
Copy link
Member

@grahamgower grahamgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xin-huang. This looks great! The failing tests are just about code style, which can be fixed by using the pre-commit tool as described in the developer docs: https://popsim-consortium.github.io/stdpopsim-docs/latest/development.html#github-workflow

After that, I think this will be good to merge. It would be good to open an issue for the demographic model QC, separate to the species QC issue.

@xin-huang
Copy link
Member Author

Hi @grahamgower
I fixed the code style. All tests are passed now.

@grahamgower grahamgower merged commit 25ac77b into popsim-consortium:main Apr 25, 2022
@grahamgower
Copy link
Member

Thanks @xin-huang. Could you please open a new issue to track the QC for the BonoboGhost_4K19 demographic model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants