Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC for HolsteinFriesian_1M13 demographic model for BosTau #1272

Merged
merged 1 commit into from May 19, 2022

Conversation

igronau
Copy link
Contributor

@igronau igronau commented May 18, 2022

[ including updated mutation rate in doc for BosTau demographic model
(HolsteinFriesian_1M13.csv) to fit the one used in model ]

[  including updated mutation rate in doc for BosTau demographic model
  (HolsteinFriesian_1M13.csv) to fit the one used in model   ]
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1272 (e7f67e3) into main (06fdd9e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1272   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         109      110    +1     
  Lines        3478     3497   +19     
  Branches      435      436    +1     
=======================================
+ Hits         3466     3485   +19     
  Misses          8        8           
  Partials        4        4           
Impacted Files Coverage Δ
stdpopsim/qc/BosTau.py 100.00% <100.00%> (ø)
stdpopsim/qc/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06fdd9e...e7f67e3. Read the comment docs.

@gregorgorjanc
Copy link
Contributor

@igronau This makes perfect sense to me! Thanks!

@petrelharp
Copy link
Contributor

Great! Is this ready to merge then, @igronau?

@igronau
Copy link
Contributor Author

igronau commented May 19, 2022

Yes.

Copy link
Member

@grahamgower grahamgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @igronau.

@grahamgower grahamgower merged commit 9fd2c57 into popsim-consortium:main May 19, 2022
@igronau igronau deleted the bos_tau_qc branch May 19, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants