Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bos taurus #600

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Add Bos taurus #600

merged 2 commits into from
Oct 2, 2020

Conversation

grahamgower
Copy link
Member

Hey @iechevarriaz, thanks for your hard work here! I've made some changes to the BosTau species, which are mostly cosmetic. The main non-cosmetic change I made was to use the ancestral Ne (62000 from MacLeod et al.) as the species default, rather than the estimate for recent years of Ne=90.

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #600 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          31       33    +2     
  Lines        2144     2167   +23     
  Branches      254      256    +2     
=======================================
+ Hits         2137     2160   +23     
  Misses          3        3           
  Partials        4        4           
Impacted Files Coverage Δ
stdpopsim/catalog/HomSap/__init__.py 100.00% <ø> (ø)
stdpopsim/catalog/PonAbe/__init__.py 100.00% <ø> (ø)
stdpopsim/__init__.py 95.83% <100.00%> (+0.18%) ⬆️
stdpopsim/catalog/BosTau/__init__.py 100.00% <100.00%> (ø)
stdpopsim/catalog/BosTau/genome_data.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bfedf...cf1e1f4. Read the comment docs.

@grahamgower
Copy link
Member Author

I'm going to merge this now, and open a couple of follow-up issues.

@grahamgower grahamgower merged commit 403e350 into popsim-consortium:master Oct 2, 2020
@grahamgower grahamgower mentioned this pull request Oct 2, 2020
@grahamgower grahamgower deleted the BosTau branch October 2, 2020 12:35
@petrelharp petrelharp mentioned this pull request May 10, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants