Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qc for AnoCar #896

Merged
merged 2 commits into from
Apr 9, 2021
Merged

qc for AnoCar #896

merged 2 commits into from
Apr 9, 2021

Conversation

andrewkern
Copy link
Member

@andrewkern andrewkern commented Apr 9, 2021

okay so we've got some QC conflicts on this one!

it looks like right now generation time and population size don't agree.

further i was unable to find a recombination rate in the citation listed.

eventually will close #895

@andrewkern
Copy link
Member Author

@Vcaudill we should figure out the differences here. for instance I've listed generation_time as 1 year, as it looks like yearlings breed in the first season.

@andrewkern
Copy link
Member Author

okay @Vcaudill and I worked through the details and this species is now good to go! 🚀 🎊

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #896 (1e46e8a) into main (8367cad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #896   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          80       80           
  Lines        2521     2521           
  Branches      285      285           
=======================================
  Hits         2506     2506           
  Misses          7        7           
  Partials        8        8           
Impacted Files Coverage Δ
stdpopsim/catalog/AnoCar/species.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8367cad...1e46e8a. Read the comment docs.

@andrewkern andrewkern merged commit 21a1ddc into popsim-consortium:main Apr 9, 2021
@andrewkern andrewkern deleted the AnoCar_qc branch April 9, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QC for Anole (AnoCar)
1 participant