Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pinned version of cpg-utils in analysis-runner web #687

Merged
merged 2 commits into from
May 29, 2024

Conversation

dancoates
Copy link
Contributor

So that the membership import statement is correct

@EddieLF
Copy link
Contributor

EddieLF commented May 29, 2024

requirements.in has cpg-utils~=5.0.1, while requirements.txt has cpg-utils==5.0.10 - are these the same?

@dancoates
Copy link
Contributor Author

dancoates commented May 29, 2024

requirements.in has cpg-utils~=5.0.1, while requirements.txt has cpg-utils==5.0.10 - are these the same?

They should be compatible if we're using semantic versioning correctly, The ~= in requirements.in means that pip-compile will specify the newest patch version >=5.0.1. The requirements.txt file is the "lock" file though, it's the ultimate source of truth of what gets installed

@@ -1,4 +1,4 @@
cpg-utils==4.18.3
cpg-utils~=5.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this will pick up the latest in the 5.0.X range? Below we have cpg-utils==5.0.10, so should this be cpg-utils~=5.0.10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have refreshed the page eh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's effectively the same thing, the requirements.in is just saying this should work with anything above 5.0.1 but less than 5.1, in some ways it is nice to keep it kind of loose, because if another dependency were to specify cpg-utils==5.0.4, pip-compile could resolve the conflict and decide to use 5.0.4. Whereas if we specified ~=5.0.10 here that wouldn't be a resolvable conflict

@dancoates dancoates merged commit 8c7d157 into main May 29, 2024
4 checks passed
@dancoates dancoates deleted the upgrade-cpg-utils-in-web branch May 29, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants