-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerise (low priority) #180
Conversation
Looks good! Manual dispatch for test builds is a good alternative (automated builds on every commit like for cpg_workflows also works good). There is a lot of documentation and formatting change in this PR besides dockerisation, is this intentional? Would be easier to split documentation and code changes into separate PRs. |
Nope, that wasn't intentional! I've changed the base branch now (I'd like the docker changes and corresponding documentation changes to be in main at the same time... but not important) |
gcloud auth configure-docker australia-southeast1-docker.pkg.dev | ||
- name: build | ||
run: | | ||
docker build . -f Dockerfile --tag $BASE_IMAGE:${{ github.sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could build this as whatever locally, not that it super matters anyway - but you're not restricted by the github.sha
* Containerise (low priority) (#180) * redraft docs (ongoing)
Fixes
Closes Make an AIP image, instead of running installs #179
Creates a Dockerfile, a reasonably extensive
.dockerignore
, and a github yaml to run the container building process.Updates bumpversion conf to update the dockerfile contents
AFAIK this repo has secrets enabled
but no runner to execute, so nothing will be built yetthe runner(s) are obviously set up for CI, Matt is just an idiotI'd like to discuss how
cpg_workflows
is built as a comparison - I'm happy either building only from main, or on deliberate invocations of the build action, rather than with every commit.I've added a secondary build file that will build an explicitly
test
version of the image, and will only run when manually invokedChecklist